feat(redis): support redis sentinel configuration#41568
Open
akantcheff wants to merge 4 commits intoappsmithorg:releasefrom
Open
feat(redis): support redis sentinel configuration#41568akantcheff wants to merge 4 commits intoappsmithorg:releasefrom
akantcheff wants to merge 4 commits intoappsmithorg:releasefrom
Conversation
Add `redis-sentinel://` scheme support in both `reactiveRedisConnectionFactory()` and `redisClient()` beans. Extract credentials parsing into a shared `extractCredentials()` method and add a `fillAuthentication()` overload for `RedisURI.Builder`. Sentinel master name is configured via `appsmith.redis.sentinel.master` property.
Add `log.info()` statements to each scheme branch (`redis`, `rediss`, `redis-sentinel`, `redis-cluster`) in `reactiveRedisConnectionFactory()` for better observability at startup.
Cover all scheme branches (standalone, SSL, sentinel, cluster), authentication variants (no auth, user+password, password-only), error cases (invalid scheme, missing sentinel master as null and empty string), and custom port.
Cover all scheme branches (standalone, SSL, sentinel, cluster), authentication variants, sentinel master validation (null and empty string), client option verification, and scheme conversion for cluster. Add `@AfterEach` cleanup for Lettuce client resources.
|
This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add Redis Sentinel support to the Appsmith server.
redis-sentinel://scheme support in bothreactiveRedisConnectionFactory()andredisClient()beansextractCredentials()method with proper validation for bothnulland empty sentinel master nameAPPSMITH_REDIS_SENTINEL_MASTERenvironment variable mapping inapplication-ce.propertiesfor consistency with otherAPPSMITH_*env varslog.info()to each scheme branch inreactiveRedisConnectionFactory()for startup observabilityConfiguration
APPSMITH_REDIS_URLredis-sentinel://sentinel-host:26379APPSMITH_REDIS_SENTINEL_MASTERmymasterAuthentication is supported via URL:
redis-sentinel://username:password@sentinel-host:26379Fixes #11976
cc @appsmithorg/query-widgets-pod
Thanks to contributors: @m-k8s @benjaminParisel @abirembaut
Automation
/ok-to-test tags=""
🔍 Cypress test results
Caution
If you modify the content in this section, you are likely to disrupt the CI result for your PR.
Communication
Should the DevRel and Marketing teams inform users about this change?