A set of unrelated fixes and features (merge via rebase merge) #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As defined in > It contains an account name, which is a URI-encoded string, > **optionally** prefixed by an issuer string identifying the provider > or service managing that account. > —https://github.com/google/google-authenticator/wiki/Key-Uri-Format#label So it was a bug that the application assumed the label always contains issuer. It led to an unexpected error when trying to add TOTP for <https://sentry.io>.
We have a wrapper function to deal with that, but for some reason, it wasn't used in a few places. This commit fixes that.
It was very inconvenient and error-prone to migrate `onetimepass` to another device without having such command: it required to manually copy the database, and manually insert the master key into the another device's keychain (!). Implementation introduced in this commit is rather crude, but works good enough as an initial version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.