Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update appuio:metrics-reader cluster role to be compatible with OpenShift 4.16 #211

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Update appuio:metrics-reader cluster role to be compatible with OpenShift 4.16 #211

merged 1 commit into from
Oct 30, 2024

Conversation

HappyTetrahedron
Copy link
Contributor

Checklist

  • The PR has a meaningful title. It will be used to auto-generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.

@HappyTetrahedron HappyTetrahedron requested a review from a team as a code owner October 28, 2024 14:44
simu
simu approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an idle thought: couldn't the modification be done as a single rule which contains the following?

          - apiGroups:
              - ""
              - metrics.k8s.io
            resources:
              - pods
            verbs:
              - get

@HappyTetrahedron HappyTetrahedron merged commit c80598e into master Oct 30, 2024
7 checks passed
@HappyTetrahedron HappyTetrahedron deleted the fix/metrics-reader-clusterrole branch October 30, 2024 10:07
@github-actions GitHub Actions
Copy link

🚀 Merging this PR will release v2.1.2

Merging will trigger workflows Release

🛠️ Auto tagging enabled with label bump:patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simu simu simu approved these changes

Assignees
No one assigned
Labels
bump:patch change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HappyTetrahedron @simu