Skip to content

fix: resolve file deletion navigation issue and improve delete modal #2054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

HarshMN2345
Copy link
Member

What does this PR do?

This PR fixes a critical bug in the storage bucket file deletion functionality where clicking the "Delete" option in the file action menu would navigate to the file preview page instead of opening the delete confirmation modal, preventing users from deleting files.

Key Changes:

  1. Fixed event handling to prevent unintended navigation when clicking delete button
  2. Added event.stopPropagation() and event.preventDefault() to action menu handlers
  3. Improved the delete confirmation modal with better file information display
  4. Enhanced UI with file metadata (type, size) and clearer warning messages about permanent deletion

Test Plan

  1. Log into the Appwrite Console and open any project
  2. Navigate to Storage → Buckets → choose any bucket
  3. Upload a test file
  4. In the file list, click the "•••" menu next to your file
  5. Click "Delete"

Related PRs and Issues

Fixes: PRO-1916 - Unable to delete file from bucket
also fixes #2052

Have you read the Contributing Guidelines on issues?

yes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets not change the UI at the moment. we can later have a discussion with the design team and decide.

@HarshMN2345 HarshMN2345 requested a review from ItzNotABug June 27, 2025 08:16
@ItzNotABug ItzNotABug merged commit dfe8d3e into appwrite:main Jun 27, 2025
2 checks passed
@HarshMN2345 HarshMN2345 deleted the fix-PRO-1916-unable-to-delete-file-from-bucket branch July 3, 2025 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storage Console “Delete” action navigates to preview instead of removing file
2 participants