Skip to content

fix:improved padding between uri and filed #2067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

HarshMN2345
Copy link
Member

@HarshMN2345 HarshMN2345 commented Jul 1, 2025

What does this PR do?

Fixes inconsistent spacing for the URI field in OAuth provider configuration modals. The URI section now has proper spacing that matches other form elements in the modal.

Changes made:

  • Updated Auth0 OAuth provider modal to use CopyInput's built-in label prop instead of a wrapper <div> with a separate <p> element.
  • Applied the same fix to the Apple OAuth provider modal.
  • Removed unnecessary wrapper <div> elements that were preventing proper spacing using the modal’s u-gap-24 system.

Before: The URI field had inconsistent spacing compared to other inputs (Client ID, Client Secret, etc.)
After: All form elements now have uniform spacing using the Modal component’s layout system.
image
image


Test Plan

  1. Navigate to Project Settings → Authentication → Auth Providers.
  2. Click "Update" on the Auth0 OAuth provider.
  3. Verify that the URI field has consistent spacing with other form inputs (Client ID, Client Secret, Auth0 Domain).
  4. Repeat for the Apple OAuth provider.
  5. Confirm spacing matches other form inputs (Services ID, Key ID, Team ID, P8 File).
  6. Check on both desktop and mobile viewports to ensure responsive behavior.

Related PRs and Issues

Fixes: SER-7 – Missing padding below OAuth callback (addresses spacing inconsistency in OAuth provider modals)


Have you read the Contributing Guidelines on issues?

Yes, I have read and understand the contributing guidelines.

@ItzNotABug ItzNotABug merged commit feb910c into appwrite:main Jul 1, 2025
2 checks passed
@HarshMN2345 HarshMN2345 deleted the fix-SER-7-Missing-padding-below-oauth-callback branch July 3, 2025 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants