feat: added promo notification for csv-import #2068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItzNotABug
requested changes
Jul 1, 2025
src/routes/(console)/bottomAlerts.ts
Outdated
| }, | ||
| show: true // For testing, will be: isPromoLive('2025-07-01', '15:00', 'Europe/Paris') | ||
| }; | ||
| if (csvImportPromo.show) { |
There was a problem hiding this comment.
we don't need this if statement if the show is try above. also remove the comment. above referring the for testing, ...
Meldiron
reviewed
Jul 1, 2025
ItzNotABug
requested changes
Jul 1, 2025
src/routes/(console)/bottomAlerts.ts
Outdated
| enabled: true, | ||
| cta: { | ||
| link: csvImportPromo.cta.link, | ||
| external: csvImportPromo.cta.external |
There was a problem hiding this comment.
we need hideOnClick here as well.
ItzNotABug
approved these changes
Jul 1, 2025
Meldiron
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CSV Import Console Notification
Description
Adds a new console notification to announce the CSV import feature. The notification will be displayed to users within project views starting July 1st, 2025 at 3 PM CET.( solves GRO-1112)
Changes
bottomAlerts.tsImplementation Details
csv-import-placeholder-dark.pngcsv-import-placeholder-light.pngTesting Instructions
show: truetemporarily in the notification configshowproperty to useisPromoLive()before mergingScreenshots
Notes