Skip to content

Fix encrypted attribute copy #2074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

HarshMN2345
Copy link
Member

What does this PR do?

This PR improves the user experience by enhancing the description text for encrypted string attributes in the collection attribute creation modal. The change splits a long sentence into two clear, separate sentences and improves the messaging around privacy compliance benefits.

Test Plan

  1. Navigate to any project's database collection
  2. Click "Create attribute" and select "String"
  3. Scroll down to the "Encrypted" checkbox section
  4. Verify the description text now shows two clear sentences:
    • "Protect attribute against data leaks for best privacy compliance."
    • "Encrypted attributes cannot be queried."
  5. Confirm the text is more readable and better explains both benefits and limitations

Related PRs and Issues

This is a standalone UI/UX improvement with no related PRs or issues.

Have you read the Contributing Guidelines on issues?

Yes, I have read and understand the Contributing Guidelines.

image

@HarshMN2345 HarshMN2345 requested a review from Copilot July 3, 2025 07:57
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Enhance the description text for encrypted string attributes to improve readability and clarify privacy compliance benefits.

  • Split a long sentence into two clear statements
  • Emphasized data leak protection and query limitation
Comments suppressed due to low confidence (1)

src/routes/(console)/project-[region]-[project]/databases/database-[database]/collection-[collection]/attributes/string.svelte:161

  • [nitpick] Consider refining the copy for clarity and grammar, e.g., "Protects the attribute against data leaks for stronger privacy compliance."
                            Protect attribute against data leaks for best privacy compliance.

@HarshMN2345 HarshMN2345 requested a review from Meldiron July 3, 2025 08:11
@Meldiron Meldiron merged commit 11c324d into appwrite:main Jul 3, 2025
2 checks passed
@HarshMN2345 HarshMN2345 deleted the fix-SER-41-Fix-encrypted--attribute-copy branch July 3, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants