fix: Disable redeploy button when sourceSize is 0
#2136
Conversation
|
The preview deployment is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2025-07-21 11:26:07 CET |
|
The preview deployment is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2025-07-21 11:26:07 CET |
| @@ -98,7 +98,7 @@ | |||
| </Button> | |||
| <svelte:fragment slot="menu" let:toggle> | |||
| <ActionMenu.Root> | |||
| {#if $canWriteFunctions} | |||
| {#if $canWriteFunctions && activeDeployment.sourceSize !== 0} | |||
There was a problem hiding this comment.
Hiding it all-together is considered bad UX, as it doesn't explain why it's sometimes disappearing. Also can cause trouble to feature discoverability.
Instead, let's just set it disabled: https://github.com/appwrite/console/blob/8381af6982a1eff132b1e40cccf6bc2ba3d508d4/src/routes/(console)/project-[region]-[project]/functions/function-[function]/(components)/downloadActionMenuItem.svelte#L26-L33
Also, let's add tooltip to explain why it's disabled, It could say something like Source is empty.
Please also add tooltip to download button I linked above, it seems to be missing it too.
There was a problem hiding this comment.
I agree disabling is much better than hiding. Since the existing pattern hid the button, I extended the same.
I'll make the change to disable all the instances.
hmacr
changed the title
sourceSize is 0sourceSize is 0
What does this PR do?
Following the pattern established in DeploymentActionMenu, this PR hides the
Redeployaction/button in other places whensourceSizeis 0.Test Plan
Manual QA: verified
Redeploybutton is hidden when deploymentsourceSizeis 0.Related PRs and Issues
#1894 where
Redeployitem was first hidden inDeploymentActionMenu.