fix: fallback to 'default' region in project switcher dropdown for se… #2139
+18
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItzNotABug
requested changes
Jul 21, 2025
| href: `${base}/project-${project.region}-${project.$id}/overview/platforms` | ||
| })); | ||
| const projectLinks = loadedProjects.projects.slice(0, 4).map((project) => { | ||
| const region = project.region || (!isCloud ? 'default' : project.region); |
There was a problem hiding this comment.
doesn't matter if cloud or not, if region isn't there, add it anyways. project.region ??= region.
| @@ -341,7 +344,7 @@ | |||
| <div use:melt={$itemProjects}> | |||
| <ActionMenu.Root> | |||
| <ActionMenu.Item.Anchor | |||
| href={`${base}/project-${project.region}-${project.$id}/overview/platforms`}> | |||
| href={`${base}/project-${project.region || (!isCloud ? 'default' : project.region)}-${project.$id}/overview/platforms`}> | |||
There was a problem hiding this comment.
lets add project.region ??= region where the project is loaded so we don't have to do this manually everywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fix: prevent undefined region in project URLs
Add fallback to 'default' when project.region is undefined to prevent URLs like project-undefined-{id}. Fixes project creation and navigation across console components.
Test Plan
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
Yes