Skip to content

Upgrade dependencies to latest #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2017
Merged

Upgrade dependencies to latest #1

merged 1 commit into from
Apr 21, 2017

Conversation

jeaye
Copy link
Contributor

@jeaye jeaye commented Apr 18, 2017

This was done using: lein ancient upgrade :check-clojure :all

All tests/specs pass locally.

This was done using: lein ancient upgrade :check-clojure :all

All tests/specs pass locally.
@aprobus aprobus merged commit a8a963e into aprobus:master Apr 21, 2017
@aprobus
Copy link
Owner

aprobus commented Apr 21, 2017

Thanks @jeaye !

@jeaye
Copy link
Contributor Author

jeaye commented Apr 21, 2017

Thank you! I'm currently waiting for a bug fix in byte-streams to be merged. At which point, I'd like to send you another PR so we can help propagate the version update up the tree.

@jeaye
Copy link
Contributor Author

jeaye commented Apr 26, 2017

@aprobus Looks like that byte-streams bit isn't going to be merged. Will you deploy a new version now?

There are a couple of other changes that could be made to JWT: the uberjar profile should, ideally, use :aot :all and the dev profile should, ideally, use *warn-on-reflection* true. After the latter is enabled, you'll find that there are several reflection warnings, which can be addressed with type hints.

It's important to address these, since that reflection is terribly slow. Here's an example of what I'm seeing:

Reflection warning, jerks_whistling_tunes/utils.clj:9:3 - call to method decode can't be resolved (target class is unknown).
Reflection warning, jerks_whistling_tunes/utils.clj:14:12 - call to method encode can't be resolved (target class is unknown).
Reflection warning, jerks_whistling_tunes/utils.clj:14:3 - call to java.lang.String ctor can't be resolved.
Reflection warning, jerks_whistling_tunes/core.clj:20:5 - call to method getBytes can't be resolved (target class is unknown).
Reflection warning, jerks_whistling_tunes/core.clj:29:7 - call to java.lang.String ctor can't be resolved.
Reflection warning, jerks_whistling_tunes/core.clj:64:22 - reference to field alg can't be resolved.
Reflection warning, jerks_whistling_tunes/core.clj:67:19 - call to method sign can't be resolved (target class is unknown).
Reflection warning, jerks_whistling_tunes/core.clj:110:23 - reference to field alg can't be resolved.
Reflection warning, jerks_whistling_tunes/core.clj:127:9 - call to method valid_signature_QMARK_ on java.lang.Object can't be resolved (no such method).
Reflection warning, jerks_whistling_tunes/sign.clj:24:16 - call to method update on java.security.Signature can't be resolved (argument types: unknown).
Reflection warning, jerks_whistling_tunes/sign.clj:35:16 - call to method initVerify on java.security.Signature can't be resolved (argument types: unknown).
Reflection warning, jerks_whistling_tunes/sign.clj:35:16 - call to method update on java.security.Signature can't be resolved (argument types: unknown).
Reflection warning, jerks_whistling_tunes/sign.clj:58:19 - call to method update on javax.crypto.Mac can't be resolved (argument types: unknown).
Reflection warning, jerks_whistling_tunes/sign.clj:106:37 - reference to field getPublic can't be resolved.
Reflection warning, jerks_whistling_tunes/sign.clj:106:54 - reference to field getPrivate can't be resolved.

Is this something you'd be willing to fix?

@aprobus
Copy link
Owner

aprobus commented May 5, 2017

@jeaye 0.3.0 should be out now. Sorry it took so long! It's been a while since I released anything to clojars and gpg was causing problems. It shouldn't be too difficult to get rid of the reflection, but I probably won't be able to get around to it for a bit.

@jeaye
Copy link
Contributor Author

jeaye commented May 5, 2017

Thank you! I think I can get to the reflection this weekend, if you don't. I did get that byte-streams bug fixed, but haven't been able to squeeze a release out of him yet. Once that happens, I'll give you another PR with the update.

Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants