Using G4VG's PlacedVolume map#349
Merged
JuanGonzalezCaminero merged 2 commits intoapt-sim:masterfrom Feb 19, 2025
Merged
Conversation
JuanGonzalezCaminero
changed the title
JuanGonzalezCaminero
force-pushed
the
g4vg_update
branch
from
a9f39cd to
9d0e6b5
Compare
JuanGonzalezCaminero
force-pushed
the
g4vg_update
branch
from
9d0e6b5 to
e890880
Compare
JuanGonzalezCaminero
changed the title
|
Can one of the admins verify this patch? |
SeverinDiederichs
approved these changes
Feb 18, 2025
Collaborator
SeverinDiederichs
left a comment
SeverinDiederichs
left a comment
There was a problem hiding this comment.
Thanks for taking care of this fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables the new G4VG option to avoid using VecGeom's reflection factory (celeritas-project/g4vg#22), which solves the wrong mapping of the daughters of reflected volumes in G4VG's PlacedVolume ID to G4 physical volume map.
Note that since we don't build the map on AdePT side anymore this change is incompatible with any previous G4VG commits.