Fix leaks in asynchronous mode #358
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Merged
agheata
pushed a commit
that referenced
this pull request
Mar 17, 2025
This PR introduces a new feature for the async mode: `/adept/FinishLastNParticlesOnCPU`. It is not complete yet, as they are currently just killed and not pushed to the CPU, as this will require #358 to work and be merged. Still, killing the last N particles can currently be used to assess some performance bottlenecks with the magnetic field. Also, a timer is added to the printout of the async printouts. This allows for the plotting the numbers of flight vs time and not just only vs iterations, as this severely skews it towards the fast iterations at the tail: <img width="637" alt="Screenshot 2025-03-16 at 10 45 45" src="https://github.com/user-attachments/assets/b09065a3-567f-4e92-8528-95d60ff3b772" />
JuanGonzalezCaminero
force-pushed
the
async_edep
branch
from
479f247 to
2e750f5
Compare
andresailer
reviewed
Mar 17, 2025
| @@ -42,6 +42,12 @@ set(CMAKE_CUDA_STANDARD_REQUIRED ${CMAKE_CXX_STANDARD_REQUIRED}) | |||
| set(CMAKE_CUDA_EXTENSIONS OFF) | |||
| set(CMAKE_INCLUDE_DIRECTORIES_PROJECT_BEFORE ON) | |||
|
|
|||
|
|
|||
| # DEBUG | |||
| # set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fsanitize=address -fno-omit-frame-pointer -g") | |||
There was a problem hiding this comment.
Can I interest you in our builds with no-omit-framepointer enabled in the compiler (gcc14fp)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.