enable full uniform B field via RK integrator#368
Merged
SeverinDiederichs merged 2 commits intoapt-sim:masterfrom Mar 25, 2025
Merged
enable full uniform B field via RK integrator#368SeverinDiederichs merged 2 commits intoapt-sim:masterfrom
SeverinDiederichs merged 2 commits intoapt-sim:masterfrom
Conversation
|
Can one of the admins verify this patch? |
agheata
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, only a constant Bz field was available.
As needed for the B5 example, a full uniform magnetic field is required. There was an not-up-to-date analytical Bany field integrator. Since it was not up to date, here I propose to simply use the RK integrator.
Now, similar to the GeneralMagneticField, a UniformMagneticField is created on the host, and passed to the device.
This cleans up quite a bit of logic on the B field.