Cleanup of tests #373
Merged
Cleanup of tests #373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuanGonzalezCaminero
force-pushed
the
track_weights
branch
from
f28e679 to
8c06319
Compare
|
Can one of the admins verify this patch? |
JuanGonzalezCaminero
force-pushed
the
track_weights
branch
from
8c06319 to
e9c0819
Compare
JuanGonzalezCaminero
force-pushed
the
track_weights
branch
from
e9c0819 to
892a563
Compare
SeverinDiederichs
approved these changes
Apr 1, 2025
Merged
SeverinDiederichs
added a commit
that referenced
this pull request
Apr 3, 2025
This mini PR fixes a minor hiccup from #373 : The copying of the gdml was flawed, if one tried to reconfigure the cmake config (e.g., switching from `-DASYNC_MODE=ON` to `OFF`) it would fail with: ``` CMake Error at test/regression/CMakeLists.txt:27 (file): file COPY cannot copy file "/home/ndiederi/software/AdePT/examples/data/testEm3.gdml" to "/home/ndiederi/software/AdePT/adept-build/testEm3.gdml/testEm3.gdml": Not a directory. ``` This PR fixes it by using the directory as destination and not the file itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving
IntegrationBenchmarkinto thetestdirectory as it is not meant to be an example. Moving old tests intotest/unitand the current validation and reproducibility intotest/regressionso that everything is registered in the same place.Changed the test scripts to output into a temporary directory to make cleanup less error-prone