Upgrade to latest g4hepem #375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeverinDiederichs
force-pushed
the
upgrade_to_latest_g4hepem
branch
from
18633c3 to
31cbce4
Compare
|
Can one of the admins verify this patch? |
SeverinDiederichs
force-pushed
the
upgrade_to_latest_g4hepem
branch
from
2b21932 to
7ffe5ef
Compare
| @@ -412,17 +415,38 @@ void CopySurfaceModelToGPU() | |||
| #endif | |||
| } | |||
|
|
|||
| G4HepEmState *InitG4HepEm() | |||
| G4HepEmState *InitG4HepEm(G4HepEmConfig *hepEmConfig) | |||
There was a problem hiding this comment.
Since these calls are a bit more complex now we could think of eventually moving them to a common header
There was a problem hiding this comment.
Noted in the codimd
JuanGonzalezCaminero
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates AdePT such that it can use the latest version of G4HepEm.
It enables to use the perRegion parameters in G4HepEm.
Furthermore, the positron cut is now used from G4HepEm. The ApplyCut value is taken directly from G4HepEm and not via a global constant. Some default parameters are set correctly. This fixes a bug, as before, if the
MinimalMSCStepLimitwas set, the results were wrong and it could even lead to stalls.This PR will also require updating the CI to the latest tagged version of G4HepEm.
In fact, the fix of the incorrect default parameters changed and fixed the physics:
