Fix global time in scoring #392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
agheata
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the global time in the scoring, as it is now passed back to Geant4. Also, a bug is fixed: for calculating the global time, the initial velocity must be used, before updating the kinetic energy due to energy loss. Before, stopped particles would then lead to an infinite global time. Now it conforms with G4.
The globalTime for secondaries is also corrected: before it was taking the globaltime from
currentTrack, however, the membercurrentTrack.globalTimewas only updated in survive, so after the secondary was created. Now the current globalTime is passed to the constructor.Now, the time seems to be fully correct in the Gauss histograms