Skip to content

Added non-consecutive reproducible track id #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 23, 2025
Merged

Conversation

agheata
Copy link
Contributor

@agheata agheata commented May 22, 2025

A uint_64 number is generated from the track seed at construction time. As long as the seed sequence is reproducible and non-clashing, so are the track id's.

To enable debugging of track N in the step range MIN-MAX: configure with ADEPT_TRACK_DEBUG=1; run like: ADEPT_DEBUG_TRACK=N ADEPT_DEBUG_MINSTEP=MIN ADEPT_DEBUG_MAXSTEP=MAX [args]

This has to be merged AFTER #387

@phsft-bot
Copy link

Can one of the admins verify this patch?

agheata added 5 commits May 22, 2025 17:12
…_TRACK=N [default 0]

Track id's are generated at track construction time in AdePT, extracting a 64-bit integer from the random state w/o advancing it.

To enable debugging of track N in the step range MIN-MAX: configure with ADEPT_TRACK_DEBUG=1; run like: ADEPT_DEBUG_TRACK=N ADEPT_DEBUG_MINSTEP=MIN ADEPT_DEBUG_MAXSTEP=MAX <executable> [args]
…ing/killing.

After kStepsStuckPush[5] small steps, the track is pushed with kPushStuck[100*kTolerance]. After kStepsStuckKill[25] the track is killed.
Copy link
Collaborator

@SeverinDiederichs SeverinDiederichs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@agheata agheata marked this pull request as ready for review May 23, 2025 06:55
@agheata agheata merged commit 49f8ce7 into apt-sim:master May 23, 2025
3 checks passed
SeverinDiederichs added a commit that referenced this pull request May 23, 2025
This fixes some leftovers from #393, as those parameters are unused if
compiled without `ADEPT_DEBUG_TRACK`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants