Skip to content

clean kernel and fix vecgeom version check #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025

Conversation

SeverinDiederichs
Copy link
Collaborator

@SeverinDiederichs SeverinDiederichs commented Jun 19, 2025

This PR cleans / fixes 3 things:

  1. a missing include of <optional> which was discovered with a different compiler
  2. it cleans the macros for the surface model for the safety calculation (which were actually only needed to ensure the correct vecgeom version) in the kernels, which can now be done that VecGeom is tagged and the surface model merged.
  3. It fixes the CMake version check logic. Due to string comparisons, all kinds of ugly misses happened. Now, it correctly identifies and rejects older versions and accepts correct versions.

@SeverinDiederichs SeverinDiederichs added the cleaning improves code clarity, readability or other label Jun 19, 2025
@phsft-bot
Copy link

Can one of the admins verify this patch?

Copy link
Contributor

@agheata agheata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

@agheata agheata merged commit 7c0aa57 into apt-sim:master Jun 19, 2025
3 checks passed
@SeverinDiederichs SeverinDiederichs deleted the cleaning_kernel branch June 23, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleaning improves code clarity, readability or other
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants