Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brian/experiment high tps qs debug #11798

Draft
wants to merge 30 commits into
base: main
Choose a base branch
from

Conversation

bchocho
Copy link
Contributor

@bchocho bchocho commented Jan 26, 2024

  • High throughput experiment
  • Reduce block size and mempool backlog
  • Block size 10k
  • Mempool backlog to 150k
  • mempool backlog to 90k
  • mempool backlog to 100k
  • Disable shuffling
  • Revert "Disable shuffling"
  • Disable waiting for full block
  • Increase block size
  • QS increase backpressure tps
  • Increase mempool backlog a bit and dial back the block size
  • Increase the bounded executor capacity
  • Test comment out verify txns
  • Improve visibility
  • Improve visibility
  • comment verification
  • Add more metrics
  • Disable sync up
  • Revert "Disable sync up"
  • Shuffle peers
  • Round robin leader election
  • Revert "Round robin leader election"
  • Disable delayed qc aggregation
  • Increase the mempool backlog
  • Block size
  • Mempool backlog to 200k
  • mempool backlog to 170k
  • Mempool backlog to 160k
  • [Quorum Store] improvements to prevent some batches not getting quorum [Quorum Store] improvements to prevent some batches not getting quorum #11629

Description

Test Plan

Copy link

trunk-io bot commented Jan 26, 2024

⏱️ 9h 40m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-unit-coverage 4h 35m 🟩
rust-smoke-coverage 3h 7m 🟩
windows-build 50m 🟩🟩
rust-unit-tests 30m 🟩
rust-images / rust-all 12m 🟩
rust-lints 9m 🟥
check 4m 🟩
check-dynamic-deps 4m 🟩🟩
run-tests-main-branch 4m 🟥
general-lints 3m 🟩
semgrep/ci 47s 🟩🟩
file_change_determinator 21s 🟩
upload-to-codecov 15s 🟩
file_change_determinator 12s 🟩
file_change_determinator 8s 🟩
permission-check 5s 🟩🟩
permission-check 4s 🟩🟩
permission-check 4s 🟩🟩
permission-check 4s 🟩🟩
permission-check 3s 🟩
determine-docker-build-metadata 2s 🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
windows-build 26m 19m +38%

settingsfeedbackdocs ⋅ learn more about trunk.io

@bchocho bchocho added the CICD:build-images when this label is present github actions will start build+push rust images from the PR. label Jan 26, 2024
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: Patch coverage is 45.04505% with 61 lines in your changes missing coverage. Please review.

Project coverage is 69.7%. Comparing base (214dcce) to head (5a71dbb).
Report is 2005 commits behind head on main.

Files with missing lines Patch % Lines
consensus/consensus-types/src/proof_of_store.rs 0.0% 22 Missing ⚠️
consensus/src/quorum_store/proof_coordinator.rs 31.8% 15 Missing ⚠️
consensus/src/round_manager.rs 55.1% 13 Missing ⚠️
consensus/src/quorum_store/counters.rs 0.0% 9 Missing ⚠️
consensus/src/consensus_provider.rs 0.0% 1 Missing ⚠️
consensus/src/quorum_store/quorum_store_builder.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             main   #11798     +/-   ##
=========================================
  Coverage    69.6%    69.7%             
=========================================
  Files        2116     2172     +56     
  Lines      401742   409601   +7859     
=========================================
+ Hits       279974   285706   +5732     
- Misses     121768   123895   +2127     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Apr 5, 2024

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

@github-actions github-actions bot added Stale and removed Stale labels Apr 5, 2024
Copy link
Contributor

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

@github-actions github-actions bot added Stale and removed Stale labels May 21, 2024
Copy link
Contributor

github-actions bot commented Jul 6, 2024

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

@github-actions github-actions bot added Stale and removed Stale labels Jul 6, 2024
Copy link
Contributor

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

@github-actions github-actions bot added Stale and removed Stale labels Aug 22, 2024
Copy link
Contributor

github-actions bot commented Oct 7, 2024

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

@github-actions github-actions bot added Stale and removed Stale labels Oct 7, 2024
Copy link
Contributor

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

@github-actions github-actions bot added Stale and removed Stale labels Nov 22, 2024
Copy link
Contributor

github-actions bot commented Jan 8, 2025

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

@github-actions github-actions bot added Stale and removed Stale labels Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:build-images when this label is present github actions will start build+push rust images from the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants