Add test-only code publish function

[alnoki]

Current problem

Currently the code module lacks test-only functions, making it difficult for devs to mock out or stub behaviors that depend on autonomous publication during runtime.

In particular, when a package is published via code::publish_package_txn(), an inner call to check_dependencies verifies that each of its dependencies have a code::PackageRegistry resource under their accounts:

aptos-core/aptos-move/framework/aptos-framework/sources/code.move

Line 273 in 66d9efb

assert!(exists<PackageRegistry>(dep.account), error::not_found(EPACKAGE_DEP_MISSING));

In the general case, the only way to ensure that a PackageRegistry exists under an account is to call code::publish_package_txn():

aptos-core/aptos-move/framework/aptos-framework/sources/code.move

Lines 155 to 157 in 66d9efb

	if (!exists<PackageRegistry>(addr)) {
	move_to(owner, PackageRegistry { packages: vector::empty() })
	};

Hence, to run a test that calls code::publish_package_txn(), there first needs to be setup that calls the same function for each of the expected dependencies. Problematically, however, this function relies on an inner call to the native_request_publish native function in code.rs, which errors out with EALREADY_REQUESTED when one attempts to publish two packages in the same txn:

aptos-core/aptos-move/framework/aptos-framework/sources/code.move

Lines 199 to 205 in 66d9efb

	// Request publish
	if (features::code_dependency_check_enabled())
	request_publish_with_allowed_deps(addr, module_names, allowed_deps, code, policy.policy)
	else
	// The new `request_publish_with_allowed_deps` has not yet rolled out, so call downwards
	// compatible code.
	request_publish(addr, module_names, code, policy.policy)

aptos-core/aptos-move/framework/src/natives/code.rs

Lines 319 to 323 in 66d9efb

	if code_context.requested_module_bundle.is_some() {
	// Can't request second time.
	return Err(SafeNativeError::Abort {
	abort_code: EALREADY_REQUESTED,
	});

Hence it is impossible to write unit tests for code that publishes a package with even a single dependency (because it is impossible to publish both the dependency and the relevant package during the same unit test, since native_request_publish throws EALREADY_REQUESTED).

For packages that have more than one dependency, it is impossible to publish even the dependencies (e.g. to ensure that a code::PackageRegistry exists under each relevant account) for the same reason.

Solution

• This PR adds a test-only code publish function, code::publish_package_txn_for_testing() which circumvents the above hassle by simply ignoring the blocking native function call (which appears to mainly serve metering purposes and occurs after all other extensive validation)
• Abstract out the publish func inner logic so that identical code (except for the offending native function call) is used both in tests and during runtime

This approach will allow developers to write unit tests for code that calls code::publish_package_txn()

Housekeeping

The following was run from repository root to ensure CI passes:

cargo build -p aptos-cached-packages
pre-commit run --all-files
scripts/rust_lint.sh
aptos move test --package-dir aptos-move/framework/aptos-framework/ --dev

[trunk-io]

⏱️ 8s total CI duration on this PR

Job	Cumulative Duration	Recent Runs
permission-check	2s	🟥
permission-check	2s	🟥
permission-check	2s	🟥
permission-check	2s	🟥

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

[github-actions]

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

[alnoki]

Bumping this as the PR eases DevEx

[github-actions]

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

[alnoki]

Bumping again as the PR eases DevEx

[github-actions]

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

[alnoki]

Bumping per stale label

[github-actions]

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

[alnoki]

Bumping per stale label

[github-actions]

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

[alnoki]

Bumping per stale label

[github-actions]

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

[alnoki]

Bumping per stale label

[gregnazario]

@alnoki please rebase and fix merge conflicts

[alnoki]

@alnoki please rebase and fix merge conflicts

@gregnazario I've just rebased and resolved all merge conflicts - does this PR now require workflow approval?

[github-actions]

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

[alnoki]

@gregnazario bumping the stale label per the requested cleanup I performed