Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mention that a comma might be expected #13650

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

brmataptos
Copy link
Contributor

Description

In case of a missing comma, mention that as part of an error message.

Fixes #13632.

How Has This Been Tested?

Added a test case based on the issue. See an existing test case also is updated.

Key Areas to Review

Is it really clearer?

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Jun 12, 2024

⏱️ 1h 2m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-targeted-unit-tests 22m 🟩
rust-move-unit-coverage 12m 🟩
rust-move-tests 12m 🟩
rust-lints 6m 🟩
run-tests-main-branch 4m 🟩
check-dynamic-deps 2m 🟩🟩
general-lints 2m 🟩
semgrep/ci 20s 🟩
file_change_determinator 11s 🟩
file_change_determinator 9s 🟩
permission-check 4s 🟩
permission-check 3s 🟩
permission-check 2s 🟩
permission-check 1s 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.0%. Comparing base (1feb429) to head (5233817).
Report is 898 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13650   +/-   ##
=======================================
  Coverage    58.9%    59.0%           
=======================================
  Files         824      824           
  Lines      198320   198327    +7     
=======================================
+ Hits       117008   117015    +7     
  Misses      81312    81312           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

│ - ^ Expected '>'
│ - ^ Expected either ',' or '>'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is a bit weird, because it's just that phatom is not a keyword

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error messages are hard, as you see.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it's not really terrible, and this is a small improvement in almost all cases, so maybe just approve?

Copy link
Contributor

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

@github-actions github-actions bot added Stale and removed Stale labels Aug 26, 2024
Copy link
Contributor

@vineethk vineethk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just leaving a test top level comment.

Copy link
Contributor

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

@github-actions github-actions bot added Stale and removed Stale labels Oct 28, 2024
Copy link
Contributor

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

@github-actions github-actions bot added Stale and removed Stale labels Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Compiler message could be nicer for missing commas in structs
3 participants