[execution window] block windows are executed #14199

bchocho · 2024-08-02T17:32:28Z

Description

Implements executing blocks and their window. While this implementation is correct, it is not very efficient. Further optimizations are needed (some noted below).

In summary, the following changes are made:

Send OrderedBlockWindow into the execution pipeline.
Concatenate the block window with the current block and execute. (No filtering/deduping is done in this PR; all previously executed transactions will be sent to execution, but will be discarded due to the sequence number.)
Change the CommitNotification sent to Quorum Store to notify batches that are removed from the block window, where previously batches that are removed from the block itself were notified.

TODO:

The execution should be gated. It probably makes sense to additionally gate via an onchain execution of the window vs no-window separate from the onchain consensus config. This will allow deployment of the block-tree changes separate from actual execution.
This PR is incompatible with Consensus Observer for now; the onchain execution config should not be turned on until Consensus Observer support is added

Type of Change

Which Components or Systems Does This Change Impact?

How Has This Been Tested?

Key Areas to Review

Checklist

I have read and followed the CONTRIBUTING doc
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I identified and added all stakeholders and component owners affected by this change as reviewers
I tested both happy and unhappy path of the functionality
I have made corresponding changes to the documentation

trunk-io · 2024-08-02T17:32:32Z

⏱️ 3h 29m total CI duration on this PR

Job	Cumulative Duration	Recent Runs
forge-e2e-test / forge	2h 14m	🟥 🟥 🟩 🟥 🟥 (+3 more)
test-target-determinator	23m	🟩 🟩 🟩
rust-move-tests	14m	🟩
rust-move-tests	9m	🟩
rust-move-tests	9m	🟩
general-lints	5m	🟩 🟩 🟩
rust-cargo-deny	5m	🟩 🟩 🟩
check-dynamic-deps	4m	🟩 🟩 🟩 🟩
semgrep/ci	1m	🟩 🟩 🟩 🟩
file_change_determinator	1m	🟩 ⬜ 🟩 🟩 🟩
file_change_determinator	42s	🟩 🟩 🟩 🟩
file_change_determinator	35s	🟩 🟩 🟩
permission-check	18s	🟩 🟩 🟩 🟩 🟩
permission-check	17s	🟩 🟩 🟩 🟩 🟩
permission-check	16s	🟩 🟩 🟩 🟩 🟩
determine-docker-build-metadata	13s	🟩 🟩 🟩
permission-check	12s	🟩 🟩 🟩 🟩 🟩
permission-check	8s	🟩 🟩 🟩
Backport PR	6s	🟥
permission-check	3s	🟩
rust-move-tests	1s	⬜

🚨 1 job on the last run was significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
test-target-determinator	8m	5m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

…store and persistent_liveness_storage. Also adds OrderedBlockWindow into PipelinedBlock. Actual execution of the block will be added to a separate PR.

## Description This PR includes a set of unit tests and test utilities for the execution window changes covered in [`brian/exec-window-base`](#14076)

…date consensus.yaml for target_block_and_round

… window

…hanges

weak pointer upgrade fail is on the OrderedBlockWindow::blocks() function

…window

Doesn't have any optimizations.

github-actions · 2025-02-21T23:40:55Z

❌ Forge suite `realistic_env_max_load` failure on `ff63687bbb71a3a3974812919037bd5524a048d2`

two traffics test: inner traffic : committed: 601.16 txn/s, submitted: 836.50 txn/s, expired: 235.34 txn/s, latency: 41047.56 ms, (p50: 50900 ms, p70: 56600, p90: 59900 ms, p99: 60800 ms), latency samples: 228577
Test Failed: test NetworkLoadTest

Caused by:
    TPS requirement for inner traffic failed. Average TPS 601.1626058992222, minimum TPS requirement 10000. Full stats: committed: 601.16 txn/s, submitted: 836.50 txn/s, expired: 235.34 txn/s, latency: 41047.56 ms, (p50: 50900 ms, p70: 56600, p90: 59900 ms, p99: 60800 ms), latency samples: 228577

Stack backtrace:
   0: anyhow::error::<impl anyhow::Error>::msg
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/anyhow-1.0.89/src/error.rs:85:36
   1: aptos_forge::success_criteria::SuccessCriteriaChecker::check_tps
             at ./testsuite/forge/src/success_criteria.rs:456:13
   2: aptos_forge::success_criteria::SuccessCriteriaChecker::check_throughput
             at ./testsuite/forge/src/success_criteria.rs:509:9
   3: aptos_forge::success_criteria::SuccessCriteriaChecker::check_core_for_success
             at ./testsuite/forge/src/success_criteria.rs:260:9
   4: <aptos_testcases::two_traffics_test::TwoTrafficsTest as aptos_testcases::NetworkLoadTest>::test::{{closure}}
             at ./testsuite/testcases/src/two_traffics_test.rs:61:13
   5: <core::pin::Pin<P> as core::future::future::Future>::poll
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/future/future.rs:123:9
   6: aptos_testcases::create_buffered_load::{{closure}}
             at ./testsuite/testcases/src/lib.rs:416:18
   7: <dyn aptos_testcases::NetworkLoadTest>::network_load_test::{{closure}}
             at ./testsuite/testcases/src/lib.rs:517:10
   8: <dyn aptos_testcases::NetworkLoadTest as aptos_forge::interface::network::NetworkTest>::run::{{closure}}
             at ./testsuite/testcases/src/lib.rs:275:14
   9: <core::pin::Pin<P> as core::future::future::Future>::poll
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/future/future.rs:123:9
  10: <aptos_testcases::two_traffics_test::TwoTrafficsTest as aptos_forge::interface::network::NetworkTest>::run::{{closure}}
             at ./testsuite/testcases/src/two_traffics_test.rs:77:47
  11: <core::pin::Pin<P> as core::future::future::Future>::poll
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/future/future.rs:123:9
  12: <aptos_testcases::CompositeNetworkTest as aptos_forge::interface::network::NetworkTest>::run::{{closure}}
             at ./testsuite/testcases/src/lib.rs:639:37
  13: <core::pin::Pin<P> as core::future::future::Future>::poll
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/future/future.rs:123:9
  14: tokio::runtime::park::CachedParkThread::block_on::{{closure}}
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/park.rs:281:63
  15: tokio::runtime::coop::with_budget
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/coop.rs:107:5
  16: tokio::runtime::coop::budget
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/coop.rs:73:5
  17: tokio::runtime::park::CachedParkThread::block_on
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/park.rs:281:31
  18: tokio::runtime::context::blocking::BlockingRegionGuard::block_on
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/context/blocking.rs:66:9
  19: tokio::runtime::handle::Handle::block_on_inner::{{closure}}
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/handle.rs:324:22
  20: tokio::runtime::context::runtime::enter_runtime
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/context/runtime.rs:65:16
  21: tokio::runtime::handle::Handle::block_on_inner
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/handle.rs:323:9
  22: tokio::runtime::handle::Handle::block_on
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/handle.rs:302:18
  23: aptos_forge::runner::Forge<F>::run
             at ./testsuite/forge/src/runner.rs:332:50
  24: forge::run_forge_with_changelog
             at ./testsuite/forge-cli/src/main.rs:428:24
  25: forge::main
             at ./testsuite/forge-cli/src/main.rs:331:21
  26: core::ops::function::FnOnce::call_once
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/ops/function.rs:250:5
  27: std::sys_common::backtrace::__rust_begin_short_backtrace
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/sys_common/backtrace.rs:155:18
  28: std::rt::lang_start::{{closure}}
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/rt.rs:166:18
  29: core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/ops/function.rs:284:13
  30: std::panicking::try::do_call
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:552:40
  31: std::panicking::try
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:516:19
  32: std::panic::catch_unwind
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panic.rs:146:14
  33: std::rt::lang_start_internal::{{closure}}
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/rt.rs:148:48
  34: std::panicking::try::do_call
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:552:40
  35: std::panicking::try
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:516:19
  36: std::panic::catch_unwind
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panic.rs:146:14
  37: std::rt::lang_start_internal
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/rt.rs:148:20
  38: main
  39: __libc_start_main
  40: _start
Trailing Log Lines:
  35: std::panicking::try
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:516:19
  36: std::panic::catch_unwind
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panic.rs:146:14
  37: std::rt::lang_start_internal
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/rt.rs:148:20
  38: main
  39: __libc_start_main
  40: _start

=== BEGIN JUNIT ===
<?xml version="1.0" encoding="UTF-8"?>
<testsuites name="forge" tests="1" failures="1" errors="0" uuid="da75a083-2411-44f4-b3bb-244050ec186e">
    <testsuite name="local" tests="1" disabled="0" errors="0" failures="1">
        <testcase name="CompositeNetworkTest(CpuChaosWrapper(network:multi-region-network-emulation(two traffics test))) with ">
            <failure message="test NetworkLoadTest

Caused by:
    TPS requirement for inner traffic failed. Average TPS 601.1626058992222, minimum TPS requirement 10000. Full stats: committed: 601.16 txn/s, submitted: 836.50 txn/s, expired: 235.34 txn/s, latency: 41047.56 ms, (p50: 50900 ms, p70: 56600, p90: 59900 ms, p99: 60800 ms), latency samples: 228577

Stack backtrace:
   0: anyhow::error::&lt;impl anyhow::Error&gt;::msg
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/anyhow-1.0.89/src/error.rs:85:36
   1: aptos_forge::success_criteria::SuccessCriteriaChecker::check_tps
             at ./testsuite/forge/src/success_criteria.rs:456:13
   2: aptos_forge::success_criteria::SuccessCriteriaChecker::check_throughput
             at ./testsuite/forge/src/success_criteria.rs:509:9
   3: aptos_forge::success_criteria::SuccessCriteriaChecker::check_core_for_success
             at ./testsuite/forge/src/success_criteria.rs:260:9
   4: &lt;aptos_testcases::two_traffics_test::TwoTrafficsTest as aptos_testcases::NetworkLoadTest&gt;::test::{{closure}}
             at ./testsuite/testcases/src/two_traffics_test.rs:61:13
   5: &lt;core::pin::Pin&lt;P&gt; as core::future::future::Future&gt;::poll
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/future/future.rs:123:9
   6: aptos_testcases::create_buffered_load::{{closure}}
             at ./testsuite/testcases/src/lib.rs:416:18
   7: &lt;dyn aptos_testcases::NetworkLoadTest&gt;::network_load_test::{{closure}}
             at ./testsuite/testcases/src/lib.rs:517:10
   8: &lt;dyn aptos_testcases::NetworkLoadTest as aptos_forge::interface::network::NetworkTest&gt;::run::{{closure}}
             at ./testsuite/testcases/src/lib.rs:275:14
   9: &lt;core::pin::Pin&lt;P&gt; as core::future::future::Future&gt;::poll
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/future/future.rs:123:9
  10: &lt;aptos_testcases::two_traffics_test::TwoTrafficsTest as aptos_forge::interface::network::NetworkTest&gt;::run::{{closure}}
             at ./testsuite/testcases/src/two_traffics_test.rs:77:47
  11: &lt;core::pin::Pin&lt;P&gt; as core::future::future::Future&gt;::poll
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/future/future.rs:123:9
  12: &lt;aptos_testcases::CompositeNetworkTest as aptos_forge::interface::network::NetworkTest&gt;::run::{{closure}}
             at ./testsuite/testcases/src/lib.rs:639:37
  13: &lt;core::pin::Pin&lt;P&gt; as core::future::future::Future&gt;::poll
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/future/future.rs:123:9
  14: tokio::runtime::park::CachedParkThread::block_on::{{closure}}
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/park.rs:281:63
  15: tokio::runtime::coop::with_budget
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/coop.rs:107:5
  16: tokio::runtime::coop::budget
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/coop.rs:73:5
  17: tokio::runtime::park::CachedParkThread::block_on
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/park.rs:281:31
  18: tokio::runtime::context::blocking::BlockingRegionGuard::block_on
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/context/blocking.rs:66:9
  19: tokio::runtime::handle::Handle::block_on_inner::{{closure}}
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/handle.rs:324:22
  20: tokio::runtime::context::runtime::enter_runtime
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/context/runtime.rs:65:16
  21: tokio::runtime::handle::Handle::block_on_inner
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/handle.rs:323:9
  22: tokio::runtime::handle::Handle::block_on
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.40.0/src/runtime/handle.rs:302:18
  23: aptos_forge::runner::Forge&lt;F&gt;::run
             at ./testsuite/forge/src/runner.rs:332:50
  24: forge::run_forge_with_changelog
             at ./testsuite/forge-cli/src/main.rs:428:24
  25: forge::main
             at ./testsuite/forge-cli/src/main.rs:331:21
  26: core::ops::function::FnOnce::call_once
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/ops/function.rs:250:5
  27: std::sys_common::backtrace::__rust_begin_short_backtrace
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/sys_common/backtrace.rs:155:18
  28: std::rt::lang_start::{{closure}}
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/rt.rs:166:18
  29: core::ops::function::impls::&lt;impl core::ops::function::FnOnce&lt;A&gt; for &amp;F&gt;::call_once
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/ops/function.rs:284:13
  30: std::panicking::try::do_call
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:552:40
  31: std::panicking::try
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:516:19
  32: std::panic::catch_unwind
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panic.rs:146:14
  33: std::rt::lang_start_internal::{{closure}}
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/rt.rs:148:48
  34: std::panicking::try::do_call
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:552:40
  35: std::panicking::try
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:516:19
  36: std::panic::catch_unwind
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panic.rs:146:14
  37: std::rt::lang_start_internal
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/rt.rs:148:20
  38: main
  39: __libc_start_main
  40: _start"/>
        </testcase>
    </testsuite>
</testsuites>
=== END JUNIT ===

Swarm logs can be found here: See fgi output for more information.
{"level":"INFO","source":{"package":"aptos_forge","file":"testsuite/forge/src/backend/k8s/cluster_helper.rs:381"},"thread_name":"main","hostname":"forge-e2e-pr-14199-1740180495-ff63687bbb71a3a3974812919037bd552","timestamp":"2025-02-21T23:40:51.536712Z","message":"Deleting namespace forge-e2e-pr-14199: Some(NamespaceStatus { conditions: None, phase: Some(\"Terminating\") })"}
{"level":"INFO","source":{"package":"aptos_forge","file":"testsuite/forge/src/backend/k8s/cluster_helper.rs:398"},"thread_name":"main","hostname":"forge-e2e-pr-14199-1740180495-ff63687bbb71a3a3974812919037bd552","timestamp":"2025-02-21T23:40:51.536743Z","message":"aptos-node resources for Forge removed in namespace: forge-e2e-pr-14199"}

failures:
    CompositeNetworkTest
Failed to run tests:
Tests Failed

test result: FAILED. 0 passed; 1 failed; 0 filtered out

Error: Tests Failed

Stack backtrace:
   0: anyhow::error::<impl anyhow::Error>::msg
             at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/anyhow-1.0.89/src/error.rs:85:36
   1: aptos_forge::runner::Forge<F>::run
             at ./testsuite/forge/src/runner.rs:358:13
   2: forge::run_forge_with_changelog
             at ./testsuite/forge-cli/src/main.rs:428:24
   3: forge::main
             at ./testsuite/forge-cli/src/main.rs:331:21
   4: core::ops::function::FnOnce::call_once
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/ops/function.rs:250:5
   5: std::sys_common::backtrace::__rust_begin_short_backtrace
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/sys_common/backtrace.rs:155:18
   6: std::rt::lang_start::{{closure}}
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/rt.rs:166:18
   7: core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/ops/function.rs:284:13
   8: std::panicking::try::do_call
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:552:40
   9: std::panicking::try
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:516:19
  10: std::panic::catch_unwind
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panic.rs:146:14
  11: std::rt::lang_start_internal::{{closure}}
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/rt.rs:148:48
  12: std::panicking::try::do_call
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:552:40
  13: std::panicking::try
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:516:19
  14: std::panic::catch_unwind
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panic.rs:146:14
  15: std::rt::lang_start_internal
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/rt.rs:148:20
  16: main
  17: __libc_start_main
  18: _start
Debugging output:
NAME                                   READY   STATUS      RESTARTS   AGE
aptos-node-0-fullnode-eforge95-0       1/1     Running     0          11m
aptos-node-0-validator-0               1/1     Running     0          11m
aptos-node-1-fullnode-eforge95-0       1/1     Running     0          11m
aptos-node-1-validator-0               1/1     Running     0          11m
aptos-node-2-fullnode-eforge95-0       1/1     Running     0          11m
aptos-node-2-validator-0               1/1     Running     0          11m
aptos-node-3-fullnode-eforge95-0       1/1     Running     0          11m
aptos-node-3-validator-0               1/1     Running     0          11m
aptos-node-4-fullnode-eforge95-0       1/1     Running     0          11m
aptos-node-4-validator-0               1/1     Running     0          11m
aptos-node-5-validator-0               1/1     Running     0          11m
aptos-node-6-validator-0               1/1     Running     0          11m
forge-testnet-deployer-z7tdq           0/1     Completed   0          12m
genesis-aptos-genesis-eforge95-pkh72   0/1     Completed   0          11m

bchocho mentioned this pull request Aug 2, 2024

[execution window] pipelined block includes block window #14103

Closed

21 tasks

bchocho changed the base branch from main to brian/exec-window-base August 2, 2024 17:33

bchocho added the CICD:run-forge-e2e-perf Run the e2e perf forge only label Aug 2, 2024

This comment has been minimized.

Sign in to view

bchocho force-pushed the brian/exec-window-base branch from 8cf4526 to 4301028 Compare August 2, 2024 21:58

bchocho force-pushed the brian/exec-window-exec-base branch from e6f6897 to ce40514 Compare August 2, 2024 22:13

This comment has been minimized.

Sign in to view

bchocho force-pushed the brian/exec-window-exec-base branch from 6d2830d to d8695a5 Compare August 12, 2024 17:53

This comment has been minimized.

Sign in to view

bchocho force-pushed the brian/exec-window-exec-base branch from a9b106e to dfe2ef5 Compare August 12, 2024 21:47

This comment has been minimized.

Sign in to view

bchocho force-pushed the brian/exec-window-exec-base branch from dfe2ef5 to c3f033f Compare August 12, 2024 22:21

This comment has been minimized.

Sign in to view

bchocho force-pushed the brian/exec-window-exec-base branch from 5a7f7b3 to 2d0364c Compare August 13, 2024 17:51

This comment has been minimized.

Sign in to view

hariria force-pushed the brian/exec-window-exec-base branch from 4e4f6d9 to 178f3fe Compare February 12, 2025 23:10

This comment has been minimized.

Sign in to view

hariria force-pushed the brian/exec-window-base branch 3 times, most recently from 9e76a27 to 6e517b6 Compare February 14, 2025 03:32

bchocho and others added 12 commits February 14, 2025 15:54

[execution-pool] Add window and block retrieval to block_tree, block_…

492556d

…store and persistent_liveness_storage. Also adds OrderedBlockWindow into PipelinedBlock. Actual execution of the block will be added to a separate PR.

[execution-pool] Remove round manager test assertion

b73e47b

[execution-pool] Initialize execution_pool_test.rs (#15204)

d6c8ef2

## Description This PR includes a set of unit tests and test utilities for the execution window changes covered in [`brian/exec-window-base`](#14076)

[execution-pool] Add consensus config v4

6436ca9

[execution-pool] BlockRetrievalRequest deprecate and turn to enum, up…

dec38d0

…date consensus.yaml for target_block_and_round

[execution-pool] Swarm test for OnChainConsensusConfig execution pool…

a629f34

… window

[execution-pool] Add implementation for BlockRetrievalRequestV2

9c7fd1e

[exec-pool] Rebase on main which included the BlockRetrievalRequest c…

1b7b78e

…hanges

[exec-pool] Rebase on latest consensus config changes

7ddeec0

[exec-pool] window_size as Option<usize>, None disable execution pool

2889694

[exec-pool] OrderedBlockWindow uses Weak pointers for blocks

823b9e0

change window root to last block _within_ the window

35ba990

hariria force-pushed the brian/exec-window-base branch from 5f66074 to 35ba990 Compare February 14, 2025 23:58

bchocho and others added 6 commits February 14, 2025 16:17

separate insert_committed_block and cleanup

b6a2ad5

remove unnecessary logs

c1b1228

[exec-pool] Test for nil block and bail if weak pointer upgrade fail

ff479bc

weak pointer upgrade fail is on the OrderedBlockWindow::blocks() function

Fix not using target_block_id

6550071

Change find_root_with_window to be consistent with get_ordered_block_…

44a4e91

…window

Execute the block window.

b5ee7fa

Doesn't have any optimizations.

bchocho force-pushed the brian/exec-window-exec-base branch from 178f3fe to b5ee7fa Compare February 21, 2025 20:45

hariria force-pushed the brian/exec-window-base branch from 44a4e91 to 7efbe75 Compare February 21, 2025 21:20

fix build

ff63687

This comment has been minimized.

Sign in to view

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[execution window] block windows are executed #14199

[execution window] block windows are executed #14199

bchocho commented Aug 2, 2024 •

edited

Loading

trunk-io bot commented Aug 2, 2024 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Feb 21, 2025

[execution window] block windows are executed #14199

Are you sure you want to change the base?

[execution window] block windows are executed #14199

Conversation

bchocho commented Aug 2, 2024 • edited Loading

Description

Type of Change

Which Components or Systems Does This Change Impact?

How Has This Been Tested?

Key Areas to Review

Checklist

trunk-io bot commented Aug 2, 2024 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Feb 21, 2025

❌ Forge suite realistic_env_max_load failure on ff63687bbb71a3a3974812919037bd5524a048d2

bchocho commented Aug 2, 2024 •

edited

Loading

trunk-io bot commented Aug 2, 2024 •

edited

Loading

❌ Forge suite `realistic_env_max_load` failure on `ff63687bbb71a3a3974812919037bd5524a048d2`