Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Not for review] #14927

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

[Not for review] #14927

wants to merge 28 commits into from
+12,110 −2,308

Conversation

vusirikala
Copy link
Contributor

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

igor-aptos and others added 27 commits October 9, 2024 17:00
@igor-aptos
[move][stdlib] Implement mem::swap native move call
3d7877e
@igor-aptos
Add vector::move_range native function
48df5f1
@igor-aptos
[move][stdlib] Add vector::split_off and vector::remove library methods
c6b2a63
@igor-aptos
Use vector::move_range to optimize vector functions
e4c8e84
@igor-aptos
testing/gas profiling for it
9255929
@igor-aptos
split_off => trim
c5e50b3
@igor-aptos
[move][framework] Enable building framework with move-2
927268c 
To be landed for the release we are ready to do so.
@igor-aptos
[move] Implement generic comparison method in move
d63207b
@igor-aptos
make comparison be lexicographical
1393161
@igor-aptos
adding gas charging and review comments
370a059
@igor-aptos
move to move-stdlib
32dd58f
@igor-aptos
try changing to enum
fcc2f52
@igor-aptos
[move-stdlib] Introduce efficient OrderedMap implementation
98103a0
@igor-aptos
Adding more tests, addressing some comments
3671695
@igor-aptos
original Guotang's commit
996b7e2
@igor-aptos
Update BTreeMap to only modify leaf node on happy path, and inline va…
406bbfd 
…lues
@igor-aptos
removed drop+copy requirement on value
a91d906
@igor-aptos
making key generic
f25035b
@igor-aptos
split order (max_degree) for inner and leaf nodes
04a4a14
@igor-aptos
using move 2 syntax
703a77b
@igor-aptos
fixing slots, and creating SlotsStorage, to add reusing slots afterwards
4dbb6c8
@igor-aptos
add reusable/preinitialized storage slots
17a7b95
@igor-aptos
updating function naming to be consistent
67412e0
@igor-aptos
addressing review comments
f3c4327
@igor-aptos
Separate BigOrderedMap and OrderedMap
750b046
@igor-aptos
Documentation and method names. handling sizes
d33bb26
@vusirikala
Initial draft
d7de285
@igor-aptos igor-aptos force-pushed the igor/btree_map branch 3 times, most recently from 99d60c6 to 766f291 Compare November 15, 2024 20:59
@igor-aptos igor-aptos force-pushed the igor/btree_map branch 2 times, most recently from b9cd6b8 to 84a8166 Compare November 23, 2024 02:49
@igor-aptos igor-aptos force-pushed the igor/btree_map branch 2 times, most recently from 95c575e to 060e05b Compare December 6, 2024 21:11
@igor-aptos igor-aptos force-pushed the igor/btree_map branch 3 times, most recently from 6f26c8b to 0eae837 Compare December 17, 2024 19:43
@igor-aptos igor-aptos force-pushed the igor/btree_map branch 19 times, most recently from e928925 to 294b435 Compare January 13, 2025 07:18
Base automatically changed from igor/btree_map to main January 13, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msmouse msmouse Awaiting requested review from msmouse msmouse is a code owner

@lightmark lightmark Awaiting requested review from lightmark lightmark is a code owner

@grao1991 grao1991 Awaiting requested review from grao1991 grao1991 is a code owner

@davidiw davidiw Awaiting requested review from davidiw davidiw is a code owner

@movekevin movekevin Awaiting requested review from movekevin movekevin is a code owner

@wrwg wrwg Awaiting requested review from wrwg wrwg is a code owner

@zekun000 zekun000 Awaiting requested review from zekun000 zekun000 is a code owner

@vgao1996 vgao1996 Awaiting requested review from vgao1996 vgao1996 is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vusirikala @igor-aptos