confidential proof update #16565
Draft
confidential proof update #16565
+95
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 32m total CI duration on this PR
|
alinush
reviewed
May 8, 2025
| @@ -1056,6 +1057,15 @@ module aptos_experimental::confidential_proof { | |||
| ) | |||
| } | |||
|
|
|||
| native fun verify_batch_range_proof_internal( | |||
There was a problem hiding this comment.
And you would just map this to the same Rust function, right?
There was a problem hiding this comment.
And we would never enable batch bulletproofs in ristretto255_bulletproofs?
There was a problem hiding this comment.
we can also "always abort" there, and reuse the feature flag for protecting this new native.
alinush
reviewed
May 8, 2025
alinush
reviewed
May 8, 2025
| @@ -113,5 +114,10 @@ pub fn all_natives( | |||
| ); | |||
| } | |||
|
|
|||
| add_natives_from_module!( | |||
There was a problem hiding this comment.
I don't see anything here that indicates confidential_proof lies in 0x7 or aptos_experimental...
Even so, will this work on testnet and mainnet? Since 0x7 is experimental and not deployed there.
|
This issue is stale because it has been open 45 days with no activity. Remove the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
Key Areas to Review
Type of Change
Which Components or Systems Does This Change Impact?
Checklist