change some IDs (#49)

aquasecurity · Dec 22, 2021 · 6ad753e · 6ad753e
1 parent 9a44f3e
commit 6ad753e
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 8 deletions.
diff --git a/loader/loader.go b/loader/loader.go
@@ -30,6 +30,7 @@ func GetProvidersHierarchy() (providers map[string]map[string][]string) {
 
 	for _, rule := range registeredRules {
 
+		cNames := make(map[string]bool)
 		pName := strings.ToLower(rule.Rule().Provider.DisplayName())
 		sName := strings.ToLower(rule.Rule().Service)
 		cName := rule.Rule().AVDID
@@ -42,13 +43,15 @@ func GetProvidersHierarchy() (providers map[string]map[string][]string) {
 			provs[pName][sName] = make([]string, 0)
 		}
 
-		provs[pName][sName] = append(provs[pName][sName], cName)
+		if _, ok := cNames[cName]; !ok {
+			cNames[cName] = true
+			provs[pName][sName] = append(provs[pName][sName], cName)
+		}
 	}
 
 	return provs
 }
 
-
 func GetProviders() (providers []Provider) {
 
 	registeredRules := rules.GetRegistered()

diff --git a/rules/aws/elasticsearch/use_secure_tls_policy.go b/rules/aws/elasticsearch/use_secure_tls_policy.go
@@ -9,7 +9,7 @@ import (
 
 var CheckUseSecureTlsPolicy = rules.Register(
 	rules.Rule{
-		AVDID:       "AVD-AWS-0047",
+		AVDID:       "AVD-AWS-0126",
 		Provider:    provider.AWSProvider,
 		Service:     "elastic-search",
 		ShortCode:   "use-secure-tls-policy",

diff --git a/rules/aws/redshift/non_default_vpc_deployment.go b/rules/aws/redshift/non_default_vpc_deployment.go
@@ -9,7 +9,7 @@ import (
 
 var CheckUsesVPC = rules.Register(
 	rules.Rule{
-		AVDID:      "AVD-AWS-0085",
+		AVDID:      "AVD-AWS-0127",
 		Provider:   provider.AWSProvider,
 		Service:    "redshift",
 		ShortCode:  "use-vpc",

diff --git a/rules/aws/sam/enable_function_tracing.go b/rules/aws/sam/enable_function_tracing.go
@@ -10,18 +10,18 @@ import (
 
 var CheckEnableFunctionTracing = rules.Register(
 	rules.Rule{
-		AVDID:       "AVD-AWS-0113",
+		AVDID:       "AVD-AWS-0125",
 		Provider:    provider.AWSProvider,
 		Service:     "sam",
 		ShortCode:   "enable-function-tracing",
 		Summary:     "SAM Function must have X-Ray tracing enabled",
 		Impact:      "Without full tracing enabled it is difficult to trace the flow of logs",
 		Resolution:  "Enable tracing",
 		Explanation: `X-Ray tracing enables end-to-end debugging and analysis of the function.`,
-		Links:       []string{
+		Links: []string{
 			"https://docs.aws.amazon.com/serverless-application-model/latest/developerguide/sam-resource-function.html#sam-function-tracing",
 		},
-		Severity:    severity.Low,
+		Severity: severity.Low,
 	},
 	func(s *state.State) (results rules.Results) {
 		for _, function := range s.AWS.SAM.Functions {

diff --git a/rules/aws/vpc/add_description_to_security_group_rule.go b/rules/aws/vpc/add_description_to_security_group_rule.go
@@ -9,7 +9,7 @@ import (
 
 var CheckAddDescriptionToSecurityGroupRule = rules.Register(
 	rules.Rule{
-		AVDID:      "AVD-AWS-0099",
+		AVDID:      "AVD-AWS-0124",
 		Provider:   provider.AWSProvider,
 		Service:    "vpc",
 		ShortCode:  "add-description-to-security-group-rule",