Extend default kubelet configlist to fit to current AWS EKS setups (1.29 and above) #1637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mmuth
commented
Jun 27, 2024
mmuth
commented
- the latest default Kubernetes setup of AWS has its kubelet config path in the added location. Proposing to extend the list of scanned paths in order to make kube-bench execution more painless and "quick start like" in default setups.
- this should fix EKS default setup clusters are not benchmarked correctly (config path missing) #1636
- the latest default Kubernetes setup of AWS has its kubelet config path in the added location. Proposing to extend the list of scanned paths in order to make kube-bench execution more painless and "quick start like" in default setups.
|
|
mmuth
changed the title
mozillazg
approved these changes
Jul 21, 2024
Contributor
mozillazg
left a comment
mozillazg
left a comment
There was a problem hiding this comment.
LGTM, Thanks for your contribution!
Contributor
Author
|
@chen-keinan could you also take a look on this? thanks :) |
Contributor
|
@chen-keinan ping~ |
afdesk
approved these changes
Oct 4, 2024
Collaborator
afdesk
left a comment
afdesk
left a comment
There was a problem hiding this comment.
thanks for the contribution!
deebhatia
pushed a commit
to VoerEirAB/kube-bench
that referenced
this pull request
Oct 14, 2024
- the latest default Kubernetes setup of AWS has its kubelet config path in the added location. Proposing to extend the list of scanned paths in order to make kube-bench execution more painless and "quick start like" in default setups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.