Closed
Conversation
d6cff8f to
4f0accb
Compare
0e454dd to
edb2fd1
Compare
Contributor
Author
|
@geyslan @rscampos @NDStrahilevitz @yanivagman Hey can you look at the performance and integration check and help me resolve them, I managed to perform the same fail factors in main #4487 #4486 #4485 |
de6929f to
250b716
Compare
250b716 to
de6929f
Compare
de6929f to
a1b0276
Compare
b8673a9 to
333dc84
Compare
53f9e2a to
1561e75
Compare
e4a8719 to
2cd433b
Compare
change tracee --grpc-listen-addr and --http-listen-addr flag to --server flag tracee-ebpf and tracee-rulse supported the old foramt, made them support the new flag format
grpc is part of the server flag. removeal of unnecassary code
This reverts commit c3bd9a89e5e7a1f66cb3b00caec6714f6d5292bd.
76dd737 to
6e60bce
Compare
Collaborator
|
Closing in favor of #4918 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
servertracee,tracee-ebpf,tracee-rulesto align with the new server flag formatgrpc-listen-addr,http-listen-addrto the same flag2375a0c974 fix: server flag is not inflags package
221d066 remove grpc flag file
edb2fd1 fix: tracee-ebpf, tracee-rules dowsnt support new flag format
cc58199 change docs for server flag
898c970 add help for server flag
5533c81 added more test to server flag
6dff62f added error handling to server
1313a9a added return nol error for function
9ee45c9 changes init of grpc server
eddcaaa added simple tests for server flag
68f18b6 fix server algorithem
aa51af1 enhanced prepareServer for better readabilty
a645543 added simple implantation of server flag
2375a0c974 fix: server flag is not inflags package
221d066 remove grpc flag file
edb2fd1 fix: tracee-ebpf, tracee-rules dowsnt support new flag format
2. Explain how to test it
Run tracese on your local machine with the server flag according to the new design, as described in the help section and docs.
this is the new design for the server flags:
this is the new design for the server config file:
server: http: metrics: false # Enable metrics endpoint pprof: false # Enable pprof endpoints healthz: false # Enable health check endpoint pyroscope: false # Enable Pyroscope agent address: ":3366" # Set HTTP server listening address (default ":3366" when not set) grpc: address: "" # Set gRPC server listening address (default: disabled)you can also run the test under
/tracee/pkg/cmd/flags3. Other comments
This Pr moves the server flag from its package to the flags that have some performance issues on tracee-rules
design in #4473
close #4388