Add security_task_prctl event #4583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oshaked1
force-pushed
the
security_task_prctl
branch
from
768f27a to
2d70e31
Compare
oshaked1
force-pushed
the
security_task_prctl
branch
5 times, most recently
from
bb5dd35 to
e73cf9a
Compare
oshaked1
force-pushed
the
security_task_prctl
branch
from
e73cf9a to
ec0be42
Compare
Member
|
Getting here soon. |
geyslan
requested changes
Mar 6, 2025
Member
geyslan
left a comment
geyslan
left a comment
There was a problem hiding this comment.
Overall LGTM. I've put some thoughts. It will be required other PR to change proto (grpc api) accommodating this new event.
geyslan
reviewed
Mar 6, 2025
oshaked1
force-pushed
the
security_task_prctl
branch
5 times, most recently
from
f24e6f1 to
55391ff
Compare
oshaked1
force-pushed
the
security_task_prctl
branch
from
55391ff to
fc47874
Compare
Contributor
oshaked1
force-pushed
the
security_task_prctl
branch
2 times, most recently
from
c149f37 to
91a4eaf
Compare
oshaked1
force-pushed
the
security_task_prctl
branch
from
91a4eaf to
d57ddfb
Compare
Contributor
Author
|
@NDStrahilevitz I added a commit that updates the translation table |
Collaborator
|
Please wait with merging this after #4353. I will +1 after aligning with it. |
Collaborator
Ok, now that its merged, just this remains. |
oshaked1
force-pushed
the
security_task_prctl
branch
2 times, most recently
from
ae891af to
1910ea7
Compare
Contributor
Author
|
@NDStrahilevitz aligned with your PR |
NDStrahilevitz
approved these changes
May 5, 2025
Collaborator
NDStrahilevitz
left a comment
NDStrahilevitz
left a comment
There was a problem hiding this comment.
LGTM in terms of the alignment. Have you tested that it renders as you expect?
Contributor
Author
|
Yes it works as expected |
Member
|
@oshaked1 would you mind rebasing it again? |
For security_task_prctl event
oshaked1
force-pushed
the
security_task_prctl
branch
2 times, most recently
from
4adc908 to
4e81fd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.