New log flag #4659
Open
New log flag #4659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geyslan
reviewed
Mar 18, 2025
Hey @geyslan, I fix your recommendations |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
0f0b952 fix PR review comments
823ff4a fix test and tracee-ebpf log flag use
5cebcba update the log flag docs
e96f03c modify the PrepareLogger
bdbe53f fix config test for log flag
2f210c7 modify root flag to the new log format
21e2031 modified logger prepare flag function to align with new config system
02b0d53 modified log config flag to align to the new format
2. Explain how to test it
the flag design is based upon the new flag design, you can view the flag design in #4474
you can test this flag by running
make test-unitand see it pass all the modified tests that are based on the old config system which means the same functionality exists with a different setup3. Other comments
close #4474