Skip to content

chore(ci): improve kernel tests #4789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

geyslan
Copy link
Member

@geyslan geyslan commented Jun 5, 2025

1. Explain what the PR does

991bb87 chore(ci): use updated RHEL8 4.18 ami with cla fix
fd2efc5 chore(ci): improve kernel tests

2. Explain how to test it

3. Other comments

@geyslan geyslan force-pushed the sleep-runners branch 12 times, most recently from 030f1c4 to 7939deb Compare June 5, 2025 20:28
@geyslan geyslan changed the title wip chore(ci): improve kernel tests Jun 5, 2025
@geyslan geyslan force-pushed the sleep-runners branch 3 times, most recently from d7b635d to b96b9f8 Compare June 6, 2025 19:28
@geyslan geyslan marked this pull request as ready for review June 6, 2025 19:32
@Copilot Copilot AI review requested due to automatic review settings June 6, 2025 19:32
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors CI kernel testing by introducing a dynamic kernel matrix, splitting it into two parallel batches, and adds support for the RHEL8 4.18 AMI.

  • Generates a test matrix from .github/kernels.csv and splits it into two jobs
  • Creates reusable workflows for single-kernel dispatch and matrix-based runs
  • Adds kernels.csv with updated AMIs, including RHEL8 4.18

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
.github/workflows/pr.yaml Refactor kernel test section: remove hard-coded env, add generate-matrix, split into two matrix jobs
.github/kernels.csv New CSV listing kernel names, architectures, and AMIs
.github/workflows/kernel-tests.yaml New workflow to lookup AMI and dispatch a single kernel test
.github/workflows/kernel-tests-matrix.yaml New matrix workflow for parallel kernel tests
.github/actions/kernel-tests/action.yaml Update composite action: set up env vars and run instrumentation, net, kernel tests
Comments suppressed due to low confidence (1)

.github/actions/kernel-tests/action.yaml:26

  • ARM64_TESTS is referenced before it’s defined. Move the ARM64_TESTS assignment above this conditional or defer exporting TESTS until after ARM64_TESTS is set to ensure the correct test list is used for aarch64.
echo "TESTS=${ARM64_TESTS}" >> "${GITHUB_ENV}"

@geyslan

This comment was marked as resolved.

@geyslan geyslan force-pushed the sleep-runners branch 2 times, most recently from 375794b to 991bb87 Compare June 9, 2025 19:58
@geyslan geyslan requested a review from trvll June 9, 2025 19:59
Copy link
Collaborator

@trvll trvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geyslan geyslan force-pushed the sleep-runners branch 5 times, most recently from a072791 to d2704cd Compare June 10, 2025 15:14
@geyslan
Copy link
Member Author

geyslan commented Jun 18, 2025

I'm converting this to draft as more info about graas was brought to our knowledgement.

@geyslan geyslan marked this pull request as draft June 18, 2025 17:03
@geyslan geyslan marked this pull request as draft June 18, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants