Added NVD CPE details #114
Open
+274
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knqyf263
reviewed
Apr 21, 2021
pkg/types/types.go
Outdated
| @@ -95,6 +95,7 @@ type VulnerabilityDetail struct { | |||
| Description string `json:",omitempty"` | |||
| PublishedDate *time.Time `json:",omitempty"` | |||
| LastModifiedDate *time.Time `json:",omitempty"` | |||
| CPEDetails string `json:",omitempty"` | |||
There was a problem hiding this comment.
We should have a struct for CPEDetails, not string.
There was a problem hiding this comment.
noted, I thought we want to optimize the storage here, so I tried storing as JSON string
There was a problem hiding this comment.
In any cases, we marshal VulnerabilityDetail to JSON in BoltDB, so the disk size would be almost the same. If we store CPEDetails as string, we need to unmarshal twice.
There was a problem hiding this comment.
Ok, pushing the change
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue