test: replace Go checks with Rego #7867
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nikpivkin <[email protected]>
Signed-off-by: nikpivkin <[email protected]>
Signed-off-by: nikpivkin <[email protected]>
nikpivkin
changed the title
Signed-off-by: nikpivkin <[email protected]>
Signed-off-by: nikpivkin <[email protected]>
Signed-off-by: nikpivkin <[email protected]>
Signed-off-by: nikpivkin <[email protected]>
Signed-off-by: nikpivkin <[email protected]>
Signed-off-by: nikpivkin <[email protected]>
nikpivkin
commented
Nov 5, 2024
Comment on lines
-257
to
-282
| name: "IgnoreForImpliedIAMResource", | ||
| inputOptions: ` | ||
| terraform { | ||
| required_version = "~> 1.1.6" | ||
|
|
||
| required_providers { | ||
| aws = { | ||
| source = "hashicorp/aws" | ||
| version = "~> 3.48" | ||
| } | ||
| } | ||
| } | ||
|
|
||
| # Retrieve an IAM group defined outside of this Terraform config. | ||
|
|
||
| # tfsec:ignore:aws-iam-enforce-mfa | ||
| data "aws_iam_group" "externally_defined_group" { | ||
| group_name = "group-name" # tfsec:ignore:aws-iam-enforce-mfa | ||
| } | ||
|
|
||
| # Create an IAM policy and attach it to the group. | ||
|
|
||
| # tfsec:ignore:aws-iam-enforce-mfa | ||
| resource "aws_iam_policy" "test_policy" { | ||
| name = "test-policy" # tfsec:ignore:aws-iam-enforce-mfa | ||
| policy = data.aws_iam_policy_document.test_policy.json # tfsec:ignore:aws-iam-enforce-mfa |
There was a problem hiding this comment.
The AVD-AWS-0123 (aws-iam-enforce-mfa) check will never be triggered for this input even without ignore rules.
There was a problem hiding this comment.
Why is that? If so is the case, was the assertion incorrect?
There was a problem hiding this comment.
aws-iam-enforce-mfa checks that the condition key is aws:MultiFactorAuthPresent. but the test data does not contain this. I also ran trivy on the test case, but it didn't produce any results:
trivy conf main.tf
2024-11-11T15:36:25+06:00 INFO [misconfig] Misconfiguration scanning is enabled
2024-11-11T15:36:26+06:00 INFO [terraform scanner] Scanning root module file_path="."
2024-11-11T15:36:26+06:00 INFO Detected config files num=1
nikpivkin
commented
Nov 5, 2024
Comment on lines
-579
to
-581
| name: "TrivyIgnoreForImpliedIAMResource", | ||
| inputOptions: ` | ||
| terraform { |
Signed-off-by: nikpivkin <[email protected]>
Signed-off-by: nikpivkin <[email protected]>
Signed-off-by: nikpivkin <[email protected]>
Signed-off-by: nikpivkin <[email protected]>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #7718
Checklist