feat(flag): Add --no-color flag to remove color from terminal output

[eschcam]

Description

Added a --no-color flag that removes all colour from logs and tables in terminal output

Related issues

• Close --no-color option #1091

[github-actions]

📊 API Changes Detected

Semver impact: major

github.com/aquasecurity/trivy/pkg/k8s/report
  Compatible changes:
  - Option.NoColor: added

github.com/aquasecurity/trivy/pkg/report/table
  Incompatible changes:
  - NewFileLicenseRenderer: changed from func(*bytes.Buffer, bool, []github.com/aquasecurity/trivy-db/pkg/types.Severity) *fileLicenseRenderer to func(*bytes.Buffer, bool, bool, []github.com/aquasecurity/trivy-db/pkg/types.Severity) *fileLicenseRenderer
  - NewMisconfigRenderer: changed from func(*bytes.Buffer, []github.com/aquasecurity/trivy-db/pkg/types.Severity, bool, bool, bool, []github.com/aquasecurity/trivy/pkg/fanal/types.ConfigType) *misconfigRenderer to func(*bytes.Buffer, []github.com/aquasecurity/trivy-db/pkg/types.Severity, bool, bool, bool, bool, []github.com/aquasecurity/trivy/pkg/fanal/types.ConfigType) *misconfigRenderer
  - NewPkgLicenseRenderer: changed from func(*bytes.Buffer, bool, []github.com/aquasecurity/trivy-db/pkg/types.Severity) *pkgLicenseRenderer to func(*bytes.Buffer, bool, bool, []github.com/aquasecurity/trivy-db/pkg/types.Severity) *pkgLicenseRenderer
  - NewSecretRenderer: changed from func(*bytes.Buffer, bool, []github.com/aquasecurity/trivy-db/pkg/types.Severity) *secretRenderer to func(*bytes.Buffer, bool, bool, []github.com/aquasecurity/trivy-db/pkg/types.Severity) *secretRenderer
  - NewSummaryRenderer: changed from func(*bytes.Buffer, bool, github.com/aquasecurity/trivy/pkg/types.Scanners) *summaryRenderer to func(*bytes.Buffer, bool, bool, github.com/aquasecurity/trivy/pkg/types.Scanners) *summaryRenderer
  - NewVulnerabilityRenderer: changed from func(*bytes.Buffer, bool, bool, bool, []github.com/aquasecurity/trivy-db/pkg/types.Severity) *vulnerabilityRenderer to func(*bytes.Buffer, bool, bool, bool, bool, []github.com/aquasecurity/trivy-db/pkg/types.Severity) *vulnerabilityRenderer
  - RenderTarget: changed from func(io.Writer, string, bool) to func(io.Writer, string, bool, bool)
  Compatible changes:
  - Options.NoColor: added

github.com/aquasecurity/trivy/pkg/flag
  Compatible changes:
  - GlobalFlagGroup.NoColor: added
  - GlobalOptions.NoColor: added
  - NoColorFlag: added
  - Options.NoColor: added

github.com/aquasecurity/trivy/pkg/log
  Incompatible changes:
  - InitLogger: changed from func(bool, bool) to func(bool, bool, bool)
  Compatible changes:
  - Options.NoColor: added

[knqyf263]

As commented here, --color=always|never|auto or --color=true|false|auto looks better to me. Also, a color library Trivy uses respects NO_COLOR. The problem seems that https://github.com/alecthomas/chroma doesn't respect NO_COLOR.

[eschcam]

As commented here, --color=always|never|auto or --color=true|false|auto looks better to me. Also, a color library Trivy uses respects NO_COLOR. The problem seems that https://github.com/alecthomas/chroma doesn't respect NO_COLOR.

--no-color makes the most sense to me as you either want the default output or the output with colour removed.
I have no idea what auto would do in the version you suggested.