Skip to content

Conversation

AliceJoubert
Copy link
Contributor

@AliceJoubert AliceJoubert commented Sep 4, 2025

Closes #1528

Non-regression tests for the pet-volume pipeline should be checked also. They don't happen upon PR opening but weekly (see our Actions).

@AliceJoubert AliceJoubert self-assigned this Sep 4, 2025
@AliceJoubert AliceJoubert added the fix PR fixing a bug label Sep 4, 2025
@AliceJoubert AliceJoubert requested review from thibaultdvx and removed request for thibaultdvx September 17, 2025 10:18
@AliceJoubert AliceJoubert merged commit d16ca3d into aramis-lab:dev Sep 19, 2025
12 of 13 checks passed
@AliceJoubert AliceJoubert deleted the pet_volume_image branch September 19, 2025 11:48
@AliceJoubert
Copy link
Contributor Author

TO VERIFY. This PR should fix the non-regression test for pet-volume currently broken with :

AttributeError: 'DynamicTraitedSpec' object has no attribute 'in_image'

@Adam-Ismaili-92
Copy link
Contributor

Adam-Ismaili-92 commented Oct 9, 2025

TO VERIFY. This PR should fix the non-regression test for pet-volume currently broken with :

AttributeError: 'DynamicTraitedSpec' object has no attribute 'in_image'

2 new errors found from weekly non-regression tests (https://github.com/aramis-lab/clinica/actions/runs/18174624005/job/51737446366) for pet-volume :

  • FAILED nonregression/pipelines/pet/test_pet_surface.py::test_pet_surface - nipype.pipeline.engine.nodes.NodeExecutionError: Exception raised while executing Node _full_pipeline_mapnode0.
  • FAILED nonregression/pipelines/pet/test_pet_surface.py::test_run_pet_surface_longitudinal - TypeError: format_clinica_file_reader_errors() missing 1 required positional argument: 'information'

No AttributeError: 'DynamicTraitedSpec' object has no attribute 'in_image'observed.

LGTM!

Copy link
Contributor

@Adam-Ismaili-92 Adam-Ismaili-92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thanks for your work @AliceJoubert !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix PR fixing a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: AttributeError in pet-volume pipeline due to incorrect 'iterfield' in MapNode

3 participants