Skip to content

Added arangodb remove starter command #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 19, 2018
Merged

Added arangodb remove starter command #187

merged 6 commits into from
Jul 19, 2018

Conversation

ewoutp
Copy link
Contributor

@ewoutp ewoutp commented Jul 19, 2018

Used to remove a starter from the cluster of starters.

@ewoutp ewoutp requested a review from neunhoef July 19, 2018 12:46
Copy link
Collaborator

@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, see comments for one typo and a suggestion for another comment in the docs.


The `remove starter` command will attempt the cleanout all data from the servers
on the machine that you want to remove.
This can take a long of time.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove "of"

It is possible to run this procedure while the machine is still running
or when it has already been removed.

It is not possible to remove machines that have an agent on it!
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about adding a comment here saying that if one has to move the starter to different hardware, one can use the recovery procedure described in the other section?

@ewoutp ewoutp merged commit c48298f into master Jul 19, 2018
@ewoutp ewoutp deleted the feature/leave-command branch July 19, 2018 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants