QA-596: special hotbackup test case for cluster deployment (topology change) #533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naushniki
force-pushed
the
feature/QA-596/clusterTopologyChange
branch
from
871f1e7 to
b4a9b14
Compare
…lusterTopologyChange
dothebart
reviewed
May 8, 2025
| self.delete_all_backups() | ||
|
|
||
| @staticmethod | ||
| def run_starter_and_wait(starter): |
There was a problem hiding this comment.
shouldn't this be a starter-manager method?
| @@ -1280,6 +1284,15 @@ def count_occurances_in_starter_log(self, substring: str): | |||
| number_of_occurances = self.get_log_file().count(substring) | |||
| return number_of_occurances | |||
|
|
|||
| def stop_dbserver(self): | |||
There was a problem hiding this comment.
this should not be a method specific to db-servers.
It should rather be
stop_instances(instance_type)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.