Avoid converting twice

`_X` and `_y` are defined to be the result of `convert` on `X` and `y` but I was accidentally using `X` and `y` rather than `_X` and `_y` in the `BetaRegressionModel` constructor, which means `convert` is called a second time unnecessarily.
ararslan · Sep 28, 2022 · 5479278 · 5479278 · ararslan · Nov 18, 2022
1 parent 947b7f3
commit 5479278
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/BetaRegression.jl b/src/BetaRegression.jl
@@ -118,8 +118,8 @@ function BetaRegressionModel(X::AbstractMatrix, y::AbstractVector,
     η = Vector{T}(undef, n)
     _X = convert(AbstractMatrix{T}, X)
     _y = convert(AbstractVector{T}, y)
-    return BetaRegressionModel{T,typeof(link),typeof(_y),typeof(_X)}(y, X, weights, offset,
-                                                                     parameters, η)
+    return BetaRegressionModel{T,typeof(link),typeof(_y),typeof(_X)}(_y, _X, weights,
+                                                                     offset, parameters, η)
 end
 
 function Base.show(io::IO, b::BetaRegressionModel{T,L}) where {T,L}