make Query interface generics consistent with Mongoose 8.15 re: #218 #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#218 is a likely cause of #232 (and Automattic/mongoose#15423). In TypeScript 5, module augmentation generics need to be exactly identical, including default values and names. This PR makes it so that
interface Query's generics line up with Mongoose 8.9.3+.Unfortunately can't make it line up exactly because Mongoose made some changes to
class Querygenerics in 8.6.0 and 8.9.3 because we weren't aware that anyone was using module augmentation with Query. TBH we didn't even know you could use module augmentation with classes 🫤 . Mongoose will keep this interface consistent in 8.x.