Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

205_ROI_Visualise_colour_change #561

Open
milesAraya opened this issue Jan 20, 2025 · 1 comment
Open

205_ROI_Visualise_colour_change #561

milesAraya opened this issue Jan 20, 2025 · 1 comment
Assignees

Comments

@milesAraya
Copy link
Collaborator

milesAraya commented Jan 20, 2025

Current situation:
In VISUALISE tab, when there is a linked ROI and timeseries window, selecting an ROI causes the timeseries to appear using setImageItemClikedDataId.
However, there is no mechanism for selecting timeseries and causing an ROI to change colour.

This was started to be implemented in this branch
feature/RoiTimeSeriesSelectColourChange

https://github.com/arayabrain/barebone-studio/pull/402/files#diff-ebcd5cf6405721e2c4588c11ab1e26be87ec4d8822f52f9dc833f7c9fa939af9

Please check the details.
Note that this approach also included integration with Edit_ROI using statusRoi


React Plus:
React plus implemented a similar feature using setRoiSelected
React Plus had good colour change feature where unselected roi become a lighter colour.


Aim:
To unify the ROI / Timeseries select features of WORKFLOW and VISUALISE tabs
In VISUALISE
When ROI are selected, they change colour (non-selected become lighter), and if fluorescence window is linked time-series is plotted.
When the legend ROI is selected the selected ROI change colour.
When ROI selected in image plot, they can be un-selected in time series plot, and when timeseries selected in fluorescence plot, they can be un-selected in ROI plot

Integration with Edit ROI: Merge ROI, Delete ROI. When ROI selected in these actions, they should also change colour (e.g. other ROI become a lighter colour)

refImageItemId is used to link windows

@milesAraya milesAraya added this to the OIST requirements 2024 milestone Jan 20, 2025
@milesAraya milesAraya self-assigned this Jan 20, 2025
@milesAraya
Copy link
Collaborator Author

This issue contains an image explaining the request
#359

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants