Roi time series select colour change #402
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milesAraya
force-pushed
the
feature/RoiTimeSeriesSelectColourChange
branch
2 times, most recently
from
c0e88cc to
0c36dda
Compare
milesAraya
force-pushed
the
feature/RoiTimeSeriesSelectColourChange
branch
from
0c36dda to
2154498
Compare
milesAraya
force-pushed
the
feature/RoiTimeSeriesSelectColourChange
branch
from
0512367 to
149e5fc
Compare
itutu-tienday
requested changes
Jan 6, 2025
| @@ -290,6 +291,14 @@ const LegendSelect: FC = () => { | |||
| drawOrderList: newDrawOrderList, | |||
| }), | |||
| ) | |||
| dispatch( | |||
There was a problem hiding this comment.
- Behavior before Edit Roi is started
- Flou selected before start of Edit Roi is not released after start of Edit Roi.
-> The selection of ROI in Edit Roi and the selection of Flou do not match.
-> When Flou is selected in this state, the ROI selection is canceled, which seems to be a reversed operation.
- Flou selected before start of Edit Roi is not released after start of Edit Roi.
| @@ -290,6 +291,14 @@ const LegendSelect: FC = () => { | |||
| drawOrderList: newDrawOrderList, | |||
| }), | |||
| ) | |||
| dispatch( | |||
There was a problem hiding this comment.
- Bug
- React error when Add Roi -> Commit -> Select the added ROI?
…eSeriesSelectColourChange
…eSeriesSelectColourChange
…eSeriesSelectColourChange
sanglevinh
force-pushed
the
feature/RoiTimeSeriesSelectColourChange
branch
from
97348be to
de83bea
Compare
…eSeriesSelectColourChange
…meSeriesSelectColourChange
milesAraya
commented
Mar 11, 2025
| selectedStatus || { | ||
| temp_add_roi: [], | ||
| temp_delete_roi: [], | ||
| temp_merge_roi: [], |
There was a problem hiding this comment.
When merging or deleting, all the ROIs turn orange or purple before selection. Actually, when turning on Merge, the ROI should have their normal colour, then only after selection to turn orange or purple.
| temp_add_roi: [], | ||
| temp_delete_roi: [], | ||
| temp_merge_roi: [], | ||
| } |
There was a problem hiding this comment.
When ROI are selected for merge, they change to purple. But after you click OK, the special Edit colour-change disappears and the ROI have their normal colours again. The two merged ROI should have the special colour until after Commit Edit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 359とOptinist repo Issue 602の解決です。
ROI が選択されると色が白に変わり、Fluorescence plotがリンクされていればtime seriesがプロットされます。
Legend ROI が選択されると ROI は白くなります。
ROI を選択解除にするとtime seriesは消えます。Legend ROIを選択解除すると ROI は通常の色に戻ります。
既存の temp_merge_roi フレームワークと同様に temp_selected_roi を使用することで実現。
When ROI are selected, they change colour to white, and if fluorescence window is linked time-series is plotted.
When the legend ROI is selected the ROI turns white.
When ROI unselected the time series disappears. When the legend is unselected the ROI returns to normal colour.
Achieved through using a temp_selected_roi, similar to the existing temp_merge_roi framework.