forked from oist/optinist
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roi time series select colour change #402
Open
milesAraya
wants to merge
21
commits into
develop-main
Choose a base branch
from
feature/RoiTimeSeriesSelectColourChange
base: develop-main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
149e5fc
cleanup files
milesAraya 34024da
Merge remote-tracking branch 'origin/feature/516' into feature/RoiTim…
sanglevinh f6b3669
add colour change
sanglevinh 6cf67ff
Fix highlight
sanglevinh b9f62de
block click roi add not commit
sanglevinh 9a0ccbd
reset roi click when commit roi
sanglevinh bf6dda7
Fix call api getTimeSeriesDataById when roi is temp add
sanglevinh 5eebc2e
remove check
sanglevinh e12c1db
revert fix error call api
sanglevinh 0f76477
Merge remote-tracking branch 'origin/feature/516' into feature/RoiTim…
sanglevinh f416ae4
Fix change colour
sanglevinh 5f268ed
Merge remote-tracking branch 'origin/feature/516' into feature/RoiTim…
sanglevinh de83bea
fix roiAlpha
sanglevinh 02546bb
Merge remote-tracking branch 'origin/feature/516' into feature/RoiTim…
sanglevinh f28ee6e
Reset all roi clicked when add, edit or delete roi
sanglevinh f1a3d2a
Merge remote-tracking branch 'origin/feature/516' into feature/RoiTim…
sanglevinh c31aae5
Add link all roi
sanglevinh 4598adb
fix roiVisualSelected undefined
sanglevinh 43fe89b
Add link fluorescence to cell roi visualize
sanglevinh fb92b12
Merge remote-tracking branch 'origin/develop-main' into feature/RoiTi…
sanglevinh 36987b2
Fix drag select roi
sanglevinh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -50,6 +50,7 @@ import { | |
setTimeSeriesItemZeroLine, | ||
setTimeSeriesItemDrawOrderList, | ||
changeRangeUnit, | ||
setClickedData, | ||
} from "store/slice/VisualizeItem/VisualizeItemSlice" | ||
import { AppDispatch } from "store/store" | ||
import { arrayEqualityFn } from "utils/EqualityUtils" | ||
|
@@ -290,6 +291,14 @@ const LegendSelect: FC = () => { | |
drawOrderList: newDrawOrderList, | ||
}), | ||
) | ||
dispatch( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
setClickedData({ | ||
itemId, | ||
clickedDataId: event.target.checked ? index : null, | ||
}), | ||
), | ||
// eslint-disable-next-line no-console | ||
console.log("#############\n In TimeSeriesItemEditor.tsx, clickedDataId") | ||
|
||
if (filePath !== null) { | ||
dispatch(getTimeSeriesDataById({ path: filePath, index: index })) | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-> The selection of ROI in Edit Roi and the selection of Flou do not match.
-> When Flou is selected in this state, the ROI selection is canceled, which seems to be a reversed operation.