Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/cell numbering #564

Merged
merged 4 commits into from
Jan 23, 2025
Merged

Feature/cell numbering #564

merged 4 commits into from
Jan 23, 2025
+112 −8

Conversation

milesAraya
Copy link
Collaborator

@milesAraya milesAraya commented Jan 22, 2025 •
edited
Loading

Add toggle feature to show all ROI in Visualise

For images please see see:
#520

Testing:
Mac M3.
Visualise, check toggle for each ROI algorithm type

  • Tutorial 1
  • Tutorial 2
  • LCCD

Video: #520 (comment)

@milesAraya milesAraya added enhancement New feature or request frontend labels Jan 22, 2025
@milesAraya milesAraya added this to the OIST requirements 2024 milestone Jan 22, 2025
@milesAraya milesAraya self-assigned this Jan 22, 2025
@milesAraya milesAraya linked an issue Jan 22, 2025 that may be closed by this pull request
[No.206]Cell numbering on Roi screen #520
Closed
itutu-tienday
itutu-tienday requested changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@itutu-tienday itutu-tienday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The specifications and operation seem to be OK.
Now, could you please record the test cases you used to check the operation? (You can also write it down in the PR description.)

itutu-tienday
itutu-tienday approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@itutu-tienday itutu-tienday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specifications and operation appear to be OK.

@milesAraya milesAraya merged commit ac7f304 into develop-main Jan 23, 2025
5 checks passed
@milesAraya milesAraya deleted the feature/cell_numbering branch January 23, 2025 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itutu-tienday itutu-tienday itutu-tienday approved these changes

Assignees

@milesAraya milesAraya

Labels
enhancement New feature or request frontend
Projects
None yet
Milestone
OIST requirements 2024
Development

Successfully merging this pull request may close these issues.

[No.206]Cell numbering on Roi screen
2 participants
@milesAraya @itutu-tienday