Porting barebone-studio nodes #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
milesAraya
reviewed
Jan 20, 2025
| K: 10 | ||
|
|
||
| gSig: [4, 4] | ||
| ssub: 1 |
There was a problem hiding this comment.
setting ssub: 2 would also be faster
There was a problem hiding this comment.
Thank you.
This setting is inherited from the original code (MATLAB), so I will keep it as it is.
It would be a good idea to discuss the optimization of the settings with the user separately.
milesAraya
approved these changes
Jan 20, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting each workflow nodes available in optinist(barebone-studio) to optinist-for-server.
Porting target nodes
*See screenshots
Testcase
Test for Porting Nodes
Test for Original Nodes
python run_expdb_batch.py)Test for Records