Conversation
Member
shedaniel
commented
Jul 16, 2022
shedaniel
commented
- This fixes chat events on fabric due to Fabric API taking priority above our mixins, we inject to the same place
- Test mod now with appended "new text" for server chat modifications and "error:" for client chat modifications
- Forge event now not cancelled for client chat modifications
shedaniel
added
bug
fabric/src/main/java/dev/architectury/impl/fabric/EventChatDecorator.java
Show resolved
Hide resolved
Member
|
Superseded by #302 |
Member
Author
|
We still need this |
Member
|
In that case, see my comments regarding the cancelling component ^^ There has to be a better way to do that :/ |
MaxNeedsSnacks
approved these changes
Sep 4, 2022
Member
|
Please resolve the merge conflicts so this can be put on last call |
Member
|
Is there still enough demand for 1.19 to warrant fixing this issue? The discourse(TM) regarding that version has largely died down, and due to CurseForge's horrible UX I would even say that publishing a new 1.19.0 release would likely confuse users into downloading said new version for their 1.19.2 instance |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.