Refactor ETL threading to support consolidateOnShutdown on multiple dataStores for a PV - Version 2 #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ches in DefaultConfigService. Instead try using Hz predicates ( which seemed to work well with GetDataAtTime ) This is a precursor to having reassignAppliance functionality. Some of the BPLs had to change as we need to set the typeinfo first before registering to the appliance
Show details based on StoragePlugin name rather than position in the array. This is needed for supporting varying datastore arrays where some PVS have STS -> MTS -> LTS and other may have STS -> SSD -> MTS -> LTS. Change some class names and variable names to reflect that ETL happens in stages. For example, ETLStage and ETLStageDetails Also some minor UI changes
We added support for this using Named Variables
Move away from one thread per lifetime to using virtual threads and sequencing one ETL stage after another. This should help support consolidateOnShutdown on multiple datastores. For example, we should now be able to support consolidateOnShutdown on both the STS and MTS.
We don't need to poll anymore
Let's see if the distributed query functions just as fast
Pause/resume using bulk operations.
|
|
Version 2 to make the merge easier. Same as before with some merge related fixes to EngineContext and some unit tests, |
jacomago
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a semi-largish change. While the unit tests seem to be passing, this needs to be tested in a production environment for impact. I plan to test this Jul-Aug during our downtime and hope for an official release in Sep.