Refactor for Python 3 #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pre-commit checks for the consistency of formatting across files, e.g. removing whitesppace characters at the end of lines or making YAML/JSON more conformant.
Code is moved into more idiomatic source directories. Functionality will need to be reenabled.
These allow us to test on multiple Python versions at once. They may need further calibration as we continue this refactor.
Imports are fixed to enabled the code to run. Linting re-formats the code as a result.
To make the utility easier to configure provenance can be controlled from the args file. Logging is slowly being implemented to provide more idiomatic feedback to the user.
ross-spencer
force-pushed
the
dev/py3
branch
2 times, most recently
from
1ca977f
to
11d97bc
Compare
original tests have been moved into the correct location. Code updates have been made as a result of basic test output. I have worked through linting issues and fixed the most pressing. There's still some refactoring to consider as the code is not particularly idiomatic. We may also have to come back to some basic functionality that is hard to understand without closer integration to the Rosetta system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is ready to merge. I'll follow up by email.
Change overview
Some next steps.
Merging
When merging, I recommend this process:
git checkout
git fetch --all
git rebase origin/main
git checkout main
git merge
git push
git branch delete
git push origin --delete
Branch naming
Once merged, I recommend changing branch name from master to main.
Giving the code a whirl
Obviously with a lot of moving pieces in this work, it probably does need
testing more thoroughly at Archives. If you find issues I will be available to
fix them.
With testing now a feature of the code, we can add new tests as we discover
new issues. It just needs to be possible to anonymize results but if so, then
the tests can make the code more and more reliable and performant.