-
Notifications
You must be signed in to change notification settings - Fork 42
tracker: migrate bug ticket creation to GitLab from Flyspray #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
fb06d82
to
0e9b672
Compare
Arch Linux no longer uses Flyspray for issue tracking. This commit updates the security tracker to generate GitLab issue URLs for package-specific vulnerability reports from the server side enabling users to create a fully populated bug report with a single click.
db.drop_all() | ||
transaction.rollback() | ||
connection.close() | ||
session.remove() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anthraxx do you mind double checking this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should leave this out for now, for sure it should be in a separate commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the very long delay, reviewed.
pkg_identifier = versions[0].base | ||
|
||
pkgname = packages[0].pkgname | ||
gitlab_url = f"https://gitlab.archlinux.org/archlinux/packaging/packages/{pkgname}/-/issues/new" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gitlab uses a special logic to encode special characters, we need that here too Basically this.
db.drop_all() | ||
transaction.rollback() | ||
connection.close() | ||
session.remove() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should leave this out for now, for sure it should be in a separate commit.
Arch Linux no longer uses Flyspray for issue tracking. This commit updates the security tracker to generate GitLab issue URLs for package-specific vulnerability reports from the server side enabling users to create a fully populated bug report with a single click.
region-compressed.mp4
Closes #222 and #223