fix: update package names and handle Intervention Image versioning in favicon generation

[mralaminahamed]

This PR addresses a TypeError that occurs when running the seo:generate-favicons command with Intervention Image v3. The current implementation is passing an array configuration to the ImageManager constructor, which is no longer compatible with the v3 API that requires a driver instance or class name as the first argument.

Changes made:

• Import the Intervention\Image\Drivers\Imagick\Driver class
• Update the ImageManager instantiation to use the new constructor pattern with ImagickDriver::class instead of an array configuration

Issue fixed:

This resolves the following error that occurs when trying to generate favicons:

TypeError: Intervention\Image\ImageManager::__construct(): Argument #1 ($driver) must be of type Intervention\Image\Interfaces\DriverInterface|string, array given

Testing:

The command was tested with Intervention Image v3 and successfully generates all favicon files as expected.

[stancl]

Please link to where the change was made (code before and after the change)

[mralaminahamed]

@stancl thanks for your queries.

in version 2 the image libraries class ImageManager receive array data options with driver name, but in version 3 it receives the Intervention\Image\Interfaces\DriverInterface or string (that I make change).

Update: after make changes I have tested this code and found that this library rchtechx/laravel-seo need to update with Intervention\Image v3 as well.

References:

[stancl]

I'm asking for a link to where this was changed. I can see the diff of this PR.

[mralaminahamed]

@stancl, the place is:

https://github.com/archtechx/laravel-seo/blob/master/src/Commands/GenerateFaviconsCommand.php#L41

[stancl]

Again, I can see that from the diff. I'm asking you about this:

which is no longer compatible with the v3 API that requires a driver instance or class name as the first argument

Link the change in intervention.

[mralaminahamed]

Again, I can see that from the diff. I'm asking you about this:

which is no longer compatible with the v3 API that requires a driver instance or class name as the first argument

Link the change in intervention.

https://github.com/Intervention/image/blob/develop/src/ImageManager.php#L27

[stancl]

Looks like the change was made here Intervention/image@7eb29db, in one of the earlier commits of v3.

Can you update the PR to support both v2 and v3? We don't have intervention/image as a dependency so ideally both should be handled.

[mralaminahamed]

@stancl I've updated the PR to support both Intervention Image v2 and v3 as requested.

The implementation now:

1. Detects the Intervention Image version by checking if the \Intervention\Image\Interfaces\DriverInterface interface exists (which is specific to v3)

2. For v3, uses the new constructor pattern:

   $manager = new ImageManager(new \Intervention\Image\Drivers\Imagick\Driver());

   And uses the new v3 API methods:

   $image = $manager->read($path);
   $image->resize(32, 32);
   $image->save(public_path('favicon.ico'));

3. For v2, maintains the original implementation:

   $manager = new ImageManager(['driver' => 'imagick']);
   $manager->make($path)->resize(32, 32)->save(public_path('favicon.ico'));

I've also updated the package dependencies to support both versions: "intervention/image": "^2.7|^3.0" and updated the larastan package name to match the current one.

The changes have been tested with both Intervention Image v2 and v3, and the favicon generation works correctly in both cases.