Skip to content

Update repositories.txt #6287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2025
Merged

Update repositories.txt #6287

merged 1 commit into from
May 10, 2025

Conversation

FarhanKhosravi
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the topic: submission Add library to the list label May 10, 2025
Copy link
Contributor

A problem was found with your submission https://github.com/FarhanKhosravi/Dynamic_Window_Filter

ERROR: Library is missing a library.properties metadata file.

See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-metadata

Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @FarhanKhosravi
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@FarhanKhosravi
Copy link
Contributor Author

@ArduinoBot please check again

Copy link
Contributor

Hello! I'm checking your submission again.

Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/FarhanKhosravi/Dynamic_Window_Filter:

Linting library in Dynamic_Window_Filter
INFO: No header file found matching library name (Dynamic_Window_Filter.h). Best practices are for primary header       
      filename to match library name.                                                                                   
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name Dynamic Window Filter contains spaces. Although supported, best practices is to not use
         spaces.                                                                                                        
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
WARNING: No example sketches found. Please provide examples.                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD004)                                                                             

Linter results for project: 0 ERRORS, 2 WARNINGS

-------------------

@github-actions github-actions bot merged commit b1b9e5f into arduino:main May 10, 2025
14 checks passed
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/FarhanKhosravi/Dynamic_Window_Filter/

github-actions bot pushed a commit that referenced this pull request May 10, 2025
FarhanKhosravi added a commit to FarhanKhosravi/library-registry that referenced this pull request May 10, 2025
@FarhanKhosravi
Copy link
Contributor Author

@ArduinoBot please check again

@per1234 per1234 self-assigned this May 10, 2025
@per1234
Copy link
Contributor

per1234 commented May 10, 2025

Hello @FarhanKhosravi. The automated system here only operates on open pull requests. Since your submission was already accepted and the pull request merged, the bot won't pay any more attention to this pull request.

The human maintainers of the repository do closely monitor the comments so that we can provide assistance or fix problems as needed. So please don't make unnecessary comments on the pull request threads.


If you found the checks that the bot performed on your library to be useful, you might consider setting up an automated check in your library repository for compliance with the Library Manager requirements. This could run on every commit and pull request to ensure such violations are caught immediately.

Arduino provides a GitHub Actions action that makes this very easy to do by adding a simple YAML file to the repository:

https://github.com/arduino/arduino-lint-action#readme

This action uses the same Arduino Lint tool as the Library Manager system.

It is in use in all the official Arduino library repositories (example).

If you have any questions about setting up such a system, we will be happy to assist you over on Arduino Forum:

https://forum.arduino.cc/c/community/general-discussion/17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants