-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: nested repeaters #2490
base: 3.x
Are you sure you want to change the base?
Fix: nested repeaters #2490
Conversation
e8f84a1
to
029f666
Compare
Hi @Tofandel, thank you so much for working on this! The only thing I'm wondering about is whether or not this change may have a breaking impact on existing revisions. |
I am currently blocking on the fact that block editors inside nested repeaters don't play well they seem to be saving as an array inside of As for breaking change, given that previously nested repeaters had no way to work (only nested blocks where working) I don't think there would be one, I'm not familiar with how revisions are created is it directly from the frontend field list and not the dirty attributes of the model? |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
6bb39cb
to
8c24885
Compare
Okay I completely rechanged the approach, I got everything working perfectly finally, schema is clean and a bit less memory hungry than before I also tested old revisions and switching backend while editing frontend since the structure is mostly the same and it's all backwards compatible, I made sure of it |
c4f61d7
to
618b3fc
Compare
Good to go now repeaters are only stored like
Instead of the original approach of
Or the current not working approach in 3.x
This is the same as how blocks are stored flattened and it seems to work just fine so I just thought let's reuse that |
618b3fc
to
f2f204d
Compare
f2f204d
to
42dd0b6
Compare
446a772
to
90fb582
Compare
50194e3
to
3002eb5
Compare
c42182f
to
ba544dd
Compare
This is great @Tofandel , thank you! |
Fixes #1060
This allows Repeaters and InlineRepeaters to be nested to infinity (or until memory is exhausted at least, since they are memory hungry)